FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-145917: Add MIME types for TTC and Haptics formats by clin1234 · Pull Request #145918 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-145917: Add MIME types for TTC and Haptics formats - #145918

Merged
hugovk merged 15 commits into
python:mainfrom
clin1234:patch-4
May 4, 2026
ConversationCommits (15)ChecksFiles changed
Merged

gh-145917: Add MIME types for TTC and Haptics formats#145918
hugovk merged 15 commits into
python:mainfrom
clin1234:patch-4

Conversation

clin1234 commented Mar 13, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

clin1234 requested a review from a team as a code owner March 13, 2026 14:19
bedevere-app Bot mentioned this pull request Mar 13, 2026
Closed
clin1234 requested a review from AA-Turner as a code owner March 13, 2026 14:27

clin1234 commented Apr 1, 2026

Copy link
Copy Markdown
Contributor Author

@StanFromIreland, @hugovk, @benediktjohannes, @encukou: would any one of you review #146344, #146342, and this? I would like for all three to be merged in before the beta cutoff.

Apologies if I sound a bit pushy.

benediktjohannes reviewed Apr 1, 2026
View reviewed changes
Comment thread Doc/whatsnew/3.15.rst Outdated

benediktjohannes Apr 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Could we maybe combine the list in one because both lists were authored by you?

clin1234 Apr 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sure.

benediktjohannes Apr 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We then need to write „and gh …“

benediktjohannes reviewed Apr 1, 2026
View reviewed changes
Comment thread Lib/mimetypes.py Outdated
benediktjohannes reviewed Apr 1, 2026
View reviewed changes
Comment thread Lib/mimetypes.py Outdated
benediktjohannes reviewed Apr 1, 2026
View reviewed changes
Comment thread Lib/mimetypes.py

benediktjohannes commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

@StanFromIreland, @hugovk, @benediktjohannes, @encukou: would any one of you review #146344, #146342, and this? I would like for all three to be merged in before the beta cutoff.

Apologies if I sound a bit pushy.

No problem! Overall looks pretty good to me, nice contributions, thanks!

benediktjohannes reviewed Apr 1, 2026
View reviewed changes

benediktjohannes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Overall looking pretty good to me! I did not look up the correctness of the applications and the entrys in official databases, but I can‘t approve the changes either because of permissions, so from what I saw when having a look on it, this LGTM, thanks!

benediktjohannes commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Please also fix Bullet list ends without a blank line; unexpected unindent

benediktjohannes reviewed Apr 11, 2026
View reviewed changes

benediktjohannes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Just one nitpick

Comment thread Misc/NEWS.d/next/Library/2026-03-13-14-23-33.gh-issue-145917.TooGKx.rst Outdated
@@ -0,0 +1,8 @@
* Add the following to ``mimetypes``:

benediktjohannes Apr 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hmm, I think that in this news entry (where it is not 3.15.rst) the „“ is not necessary because this file itself is considered to be one entry in a list and therefore the „“ is then added automatically, but I may be mistaken. This also needs to be changed in the other PRs please. And also the contributor statement and potentially other elements which were moved to the right (due to this change) might need to get back again, please. But I might be mistaken. Is there any unit test suggesting this change?

benediktjohannes Apr 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

By the way: The rest looks quite good to me from a Short Overview, thank You very much for contributing!

benediktjohannes commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

Thank you very much, looks great to me!

benediktjohannes commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

(I have not checked all mime types for correctness (e.g. typing, …) but just had a overview look on the PR in general, but based on my short review, I think that this is nice!)

benediktjohannes commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

Unforetunately, we got (at least one) failing Check, but this first one seems to be unrelated, but please also have a look lateron on the potentially failing Checks whether they Are related or not because I didn’t Check on Small things Like Syntax

freakboy3742 removed their request for review April 16, 2026 22:37
savannahostrowski removed their request for review April 17, 2026 15:12

clin1234 commented Apr 17, 2026

Copy link
Copy Markdown
Contributor Author

@StanFromIreland, @hugovk, @benediktjohannes, @encukou: would any one of you review #146344, #146342, and this? Finally got CI to not nag at me...

clin1234 commented May 4, 2026

Copy link
Copy Markdown
Contributor Author

Will this be merged in before beta1, and can this still be merged in during the beta releases?

hugovk approved these changes May 4, 2026
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2026-03-13-14-23-33.gh-issue-145917.TooGKx.rst Outdated

hugovk commented May 4, 2026

Copy link
Copy Markdown
Member

Yes, we can merge this before b1, just one suggestion to make the NEWS a bit shorter.

read-the-docs-community Bot commented May 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #32528752 | 📁 Comparing aecd96e against main (2faceee)

  🔍 Preview build  

105 files changed · + 1 added · ± 104 modified

+ Added

± Modified

Update Misc/NEWS.d/next/Library/2026-03-13-14-23-33.gh-issue-145917.T…
c0a5b36 
…ooGKx.rst

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

hugovk commented May 4, 2026

Copy link
Copy Markdown
Member

CI failure: I think the GH web editor has inserted the wrong CRLF line endings...

Please could you edit locally and replace with the usual LF?

hugovk commented May 4, 2026

Copy link
Copy Markdown
Member

Thanks!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk approved these changes
+1 more reviewer
benediktjohannes benediktjohannes left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL