JIT: missing type watcher in _CHECK_ATTR_CLASS · Issue #148398 · python/cpython · GitHub

Bug report

Bug description:

_CHECK_ATTR_CLASS calls sym_set_const(owner, type) without installing a type watcher. If the type mutates, the executor isn't invalidated.

cpython/Python/optimizer_bytecodes.c

Lines 224 to 228 in a059e85

    
               } 
        
               else { 
        
                   sym_set_const(owner, type); 
        
               } 
        
           }

Should install a watcher like _GUARD_TYPE_VERSION does:

cpython/Python/optimizer_bytecodes.c

Lines 246 to 250 in a059e85

    
               if (sym_set_type_version(owner, type_version)) { 
        
                   PyType_Watch(TYPE_WATCHER_ID, (PyObject *)type); 
        
                   _Py_BloomFilter_Add(dependencies, type); 
        
               } 
        
           }

Found by @Fidget-Spinner in #148394 (comment)

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Linked PRs

gh-148398: add type watcher in _CHECK_ATTR_CLASS #148399

pythongh-148398: add type watcher in `_CHECK_ATTR_CLASS`

pythongh-148398: add NEWS

Merge branch 'main' into pythongh-148398/add-type-watcher

pythongh-148398: add type watcher in `_CHECK_ATTR_CLASS`

gh-148398: add type watcher in `_CHECK_ATTR_CLASS` (GH-148399)

pythongh-148398: add type watcher in `_CHECK_ATTR_CLASS` (pythonGH-14…

JIT: missing type watcher in _CHECK_ATTR_CLASS · Issue #148398 · python/cpython · GitHub

Repository navigation

JIT: missing type watcher in _CHECK_ATTR_CLASS #148398

Bug report

Bug description:

CPython versions tested on:

Operating systems tested on:

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	if (sym_set_type_version(owner, type_version)) {
	PyType_Watch(TYPE_WATCHER_ID, (PyObject *)type);
	_Py_BloomFilter_Add(dependencies, type);
	}
	}

JIT: missing type watcher in _CHECK_ATTR_CLASS · Issue #148398 · python/cpython · GitHub

Repository navigation

JIT: missing type watcher in _CHECK_ATTR_CLASS #148398

Description

Bug report

Bug description:

CPython versions tested on:

Operating systems tested on:

Linked PRs

Activity

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions