Repository navigation
Remove (or integrate to CI/pyperformance) Module/_decimal/tests #149755
Description
Activity
- changed the title [-]Remove (or integrate to CI/pyperformance) tests in Module/_decimal/tests[/-] [+]Remove (or integrate to CI/pyperformance) Module/_decimal/tests[/+] on May 13, 2026
I think we should just remove the benchmark and fix tests (i.e. hash issue).
It's not practical to run this in CI, it overlaps with the regular test_decimal, but perhaps it's good to have this alive as more extensive test suite, checking both (C and pure-Python) implementations. I don't think this will be broken often, based on prior experience: for 10+ years there is only two issues (see description).
This is a follow-up of #115119.
The bench.py script already partially integrated to the pyperformance, see python/pyperformance#473.
The Modules/_decimal/tests/deccheck.py currently is broken. Even with the patch
I still got
$ ./python Modules/_decimal/tests/deccheck.py --short Random seed: 1778644369 testing __abs__ ... prec: 3 emin: -3 emax: 3 [...] testing __hash__ ... prec: 3 emin: -3 emax: 3 Traceback (most recent call last): [...] File "/home/sk/src/cpython/Modules/_decimal/tests/deccheck.py", line 570, in skip_error return getattr(shandler, t.funcname, shandler.default)(t) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^ TypeError: 'NoneType' object is not callableProbably these tests now are partially overlap with the CI tests. I think we should investigate this and merge tests or just run deccheck.py as part of CPython test suite.
Linked PRs