Repository navigation
wsgiref doesn't appear to ever set REMOTE_HOST in the environ #66425
Description
| BPO | 22229 |
|---|---|
| Nosy | @pjeby, @alex, @berkerpeksag, @isidentical |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = None
created_at = <Date 2014-08-19.17:34:05.563>
labels = ['type-bug', 'library']
title = "wsgiref doesn't appear to ever set REMOTE_HOST in the environ"
updated_at = <Date 2019-11-18.22:03:20.358>
user = 'https://github.com/alex'bugs.python.org fields:
activity = <Date 2019-11-18.22:03:20.358>
actor = 'BTaskaya'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2014-08-19.17:34:05.563>
creator = 'alex'
dependencies = []
files = []
hgrepos = []
issue_num = 22229
keywords = []
message_count = 2.0
messages = ['225534', '356918']
nosy_count = 4.0
nosy_names = ['pje', 'alex', 'berker.peksag', 'BTaskaya']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'needs patch'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue22229'
versions = ['Python 3.4', 'Python 3.5']
Activity
alex commented on Aug 19, 2014
Based on a reading of the code:
https://github.com/python/cpython/blob/master/Lib/wsgiref/simple_server.py#L88-L90
is where REMOTE_HOST is set.
However, address_string always returns self.client_address[0] (https://github.com/python/cpython/blob/master/Lib/http/server.py#L568), which means that != comparison always returns False, which means REMOTE_HOST is never actually set correctly.
isidentical commented on Nov 18, 2019
I didn't understand the issue. WSGIRequestHandler can be subclassed and address_string method may return something else.
pythongh-66425: Remove the unreachable code to set REMOTE_HOST header…
gh-66425: Remove the unreachable code to set `REMOTE_HOST` header (gh…
corona10 commented on Oct 29, 2023
Merge the PR, Even if someone overrides WSGIRequestHandler there is the documentation that the user should care about: https://docs.python.org/3/library/wsgiref.html?highlight=wsgirequesthandler#wsgiref.simple_server.WSGIRequestHandler
pythongh-66425: Remove the unreachable code to set `REMOTE_HOST` head…
pythongh-66425: Remove the unreachable code to set `REMOTE_HOST` head…
pythongh-66425: Remove the unreachable code to set `REMOTE_HOST` head…
pythongh-66425: Remove the unreachable code to set `REMOTE_HOST` head…