Repository navigation
[sqlite3] optimise transaction control functions #89203
Description
| BPO | 45040 |
|---|---|
| Nosy | @pablogsal, @erlend-aasland |
| PRs |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2021-09-19.22:51:56.846>
created_at = <Date 2021-08-28.20:16:36.873>
labels = ['extension-modules', 'type-feature', '3.11']
title = '[sqlite3] optimise transaction control functions'
updated_at = <Date 2021-09-19.22:51:56.846>
user = 'https://github.com/erlend-aasland'bugs.python.org fields:
activity = <Date 2021-09-19.22:51:56.846>
actor = 'pablogsal'
assignee = 'none'
closed = True
closed_date = <Date 2021-09-19.22:51:56.846>
closer = 'pablogsal'
components = ['Extension Modules']
creation = <Date 2021-08-28.20:16:36.873>
creator = 'erlendaasland'
dependencies = []
files = []
hgrepos = []
issue_num = 45040
keywords = ['patch']
message_count = 2.0
messages = ['400501', '402179']
nosy_count = 2.0
nosy_names = ['pablogsal', 'erlendaasland']
pr_nums = ['28019']
priority = 'low'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue45040'
versions = ['Python 3.11']
Activity
erlend-aasland commented on Aug 28, 2021
pysqlite_connection_commit_impl(), pysqlite_connection_rollback_impl(), and begin_transaction() can be simplified:
sqlite3_finalize() will pass on any error set by sqlite3_step(). This implies that we only need to check the return value of sqlite3_prepare_v2() and sqlite3_finalize(), which implies that we can execute sqlite3_prepare_v2(), sqlite3_step() and sqlite3_finalize() in a row inside a begin/end threads wrapper. As a result, error handling will be greatly simplified.
Fewer lines of code, simpler error paths, increased readability, and increased code coverage.
diffstat: 2 files changed, 27 insertions(+), 62 deletions(-)
pablogsal commented on Sep 19, 2021
New changeset 771a546 by Erlend Egeberg Aasland in branch 'main':
bpo-45040: Simplify sqlite3 transaction control functions (GH-28019)
771a546