FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-116935: Document that heap types need to support garbage collection by savannahostrowski · Pull Request #118021 · python/cpython · GitHub

/ cpython Public

gh-116935: Document that heap types need to support garbage collection - #118021

Merged
encukou merged 8 commits into
python:mainfrom
savannahostrowski:fix-116935
Apr 19, 2024
ConversationCommits (8)ChecksFiles changed
Merged

gh-116935: Document that heap types need to support garbage collection#118021
encukou merged 8 commits into
python:mainfrom
savannahostrowski:fix-116935

Conversation

savannahostrowski commented Apr 18, 2024 •
edited by encukou
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Apr 18, 2024
Closed
bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels Apr 18, 2024

encukou commented Apr 18, 2024

Copy link
Copy Markdown
Member

Thank you for the addition!
Could you please add a link to Supporting Cyclic Garbage Collection, so readers can learn about the details if they don't already know them?

savannahostrowski mentioned this pull request Apr 19, 2024
Merged
savannahostrowski commented Apr 19, 2024
View reviewed changes
Comment thread Doc/c-api/typeobj.rst Outdated
JelleZijlstra approved these changes Apr 19, 2024
View reviewed changes

JelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The wording looks good but I'd like another review from someone who is more familiar with the C API.

kalebers approved these changes Apr 19, 2024
View reviewed changes

kalebers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Well done, thanks for adding helpful information!

encukou reviewed Apr 19, 2024
View reviewed changes
Comment thread Doc/c-api/typeobj.rst Outdated
encukou enabled auto-merge (squash) April 19, 2024 09:01
encukou added the needs backport to 3.12 only security fixes label Apr 19, 2024
encukou merged commit 5d54436 into python:main Apr 19, 2024

miss-islington-app Bot commented Apr 19, 2024

Copy link
Copy Markdown

Thanks @savannahostrowski for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 19, 2024
pythongh-116935: Document that heap types need to support garbage col…
286137a 
…lection (pythonGH-118021)

(cherry picked from commit 5d54436)

Co-authored-by: Savannah Ostrowski <savannahostrowski@gmail.com>

bedevere-app Bot commented Apr 19, 2024

Copy link
Copy Markdown

GH-118092 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Apr 19, 2024
encukou pushed a commit that referenced this pull request Apr 19, 2024
[3.12] gh-116935: Document that heap types need to support garbage co…
f278b8f 
…llection (GH-118021) (GH-118092)

gh-116935: Document that heap types need to support garbage collection (GH-118021)
(cherry picked from commit 5d54436)

Co-authored-by: Savannah Ostrowski <savannahostrowski@gmail.com>

savannahostrowski commented Apr 19, 2024

Copy link
Copy Markdown
Member Author

Thanks for the reviews, folks!

savannahostrowski deleted the fix-116935 branch September 27, 2024 16:55
neonene mentioned this pull request Sep 17, 2025
Merged
7 tasks
vfazio mentioned this pull request Apr 11, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

encukou encukou approved these changes
JelleZijlstra JelleZijlstra approved these changes
+1 more reviewer
kalebers kalebers approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

docs(easy): Document that heap types need to support garbage collection

4 participants

Back | FazBrowse Home | New Git URL