| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| import pickle | ||
| import threading | ||
| import unittest | ||
|
|
||
| from test.support import threading_helper | ||
|
|
||
|
|
||
| @threading_helper.requires_working_threading() | ||
| class TestPickleFreeThreading(unittest.TestCase): | ||
|
|
||
| def test_pickle_dumps_with_concurrent_dict_mutation(self): | ||
| # gh-146452: Pickling a dict while another thread mutates it | ||
| # used to segfault. batch_dict_exact() iterated dict items via | ||
| # PyDict_Next() which returns borrowed references, and a | ||
| # concurrent pop/replace could free the value before Py_INCREF | ||
| # got to it. | ||
| shared = {str(i): list(range(20)) for i in range(50)} | ||
|
|
||
| def dumper(): | ||
| for _ in range(1000): | ||
| try: | ||
| pickle.dumps(shared) | ||
| except RuntimeError: | ||
| # "dictionary changed size during iteration" is expected | ||
| pass | ||
|
|
||
| def mutator(): | ||
| for j in range(1000): | ||
| key = str(j % 50) | ||
| shared[key] = list(range(j % 20)) | ||
| if j % 10 == 0: | ||
| shared.pop(key, None) | ||
| shared[key] = [j] | ||
|
|
||
| threads = [] | ||
| for _ in range(10): | ||
| threads.append(threading.Thread(target=dumper)) | ||
| threads.append(threading.Thread(target=mutator)) | ||
|
|
||
| with threading_helper.start_threads(threads): | ||
| pass | ||
|
|
||
| if __name__ == "__main__": | ||
| unittest.main() |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Fix segfault in :mod:`pickle` when pickling a dictionary concurrently | ||
| mutated by another thread in the free-threaded build. | ||
| Back | FazBrowse Home | New Git URL |
Uh oh!
There was an error while loading. Please reload this page.