FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add Greek translation by lysnikolaou · Pull Request #248 · python/docsbuild-scripts · GitHub

Repository navigation

Add Greek translation - #248

Merged
AA-Turner merged 6 commits into
python:mainfrom
lysnikolaou:add-gr-translation
Jun 20, 2025
Merged

AA-Turner merged 6 commits into
python:mainfrom
lysnikolaou:add-gr-translation

Conversation

Copy link
Copy Markdown
Member
  • Add Greek translation (we think we're okay to add this to production since we've done 100% of the prerequisites. If someone could double-check that, it'd be great!
  • Because the iso639 tag for Greek is el, but the more common name is gr, we'd named the repository python-docs-gr. I've added the ability to have an alternative repository name. If people think that's a bad idea, we can always rename the repository as well.

m-aciek commented Feb 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Because the iso639 tag for Greek is el, but the more common name is gr, we'd named the repository python-docs-gr. I've added the ability to have an alternative repository name. If people think that's a bad idea, we can always rename the repository as well.

If we keep the common name, would it be worth to mention allowing exceptions in the repository name in PEP 545? https://peps.python.org/pep-0545/#create-github-repository

Create a repository named “python-docs-{LANGUAGE_TAG}” (IETF language tag, without redundant region subtag, with a dash, and lowercased.) on the Python GitHub organization (See Repository For Po Files.), and grant the language coordinator push rights to this repository.

Maybe: ?

Create a repository named “python-docs-{LANGUAGE_TAG}” (without redundant region subtag, with a dash, and lowercased; IETF language tag is recommended) on the Python GitHub organization (See Repository For Po Files.), and grant the language coordinator push rights to this repository.

hugovk commented Feb 14, 2025

Copy link
Copy Markdown
Member

Re: https://peps.python.org/pep-0545/#add-translation-to-the-language-switcher

As soon as the translation hits:

  • 100% of bugs.html with proper links to the language repository issue tracker.

https://python-docs-gr.readthedocs.io/el/latest/bugs.html

Looks good.

  • 100% of tutorial.

https://python-docs-gr.readthedocs.io/el/latest/tutorial/index.html

A spot check found a little bit of English in https://python-docs-gr.readthedocs.io/el/latest/tutorial/errors.html#handling-exceptions

  • 100% of library/functions (builtins).

Looks good, except for abs: https://python-docs-gr.readthedocs.io/el/latest/library/functions.html#abs

the translation can be added to the language switcher.

Copy link
Copy Markdown
Member Author

A spot check found a little bit of English in python-docs-gr.readthedocs.io/el/latest/tutorial/errors.html#handling-exceptions

Hmm, that's odd. It looks like this is implemented in the po file.

Looks good, except for abs: python-docs-gr.readthedocs.io/el/latest/library/functions.html#abs

Again, same thing. It looks like this is implemented in the po file, but does not appear in the built docs.

Does anyone have an idea on why that might be?

m-aciek commented Feb 14, 2025

Copy link
Copy Markdown
Contributor

@lysnikolaou most probably there's a slight change in the original sources, on 3.13 branch, it would be best to update the files with the latest sources version.

Copy link
Copy Markdown

Looks good, except for abs: python-docs-gr.readthedocs.io/el/latest/library/functions.html#abs

You can see this behavior also in Spanish version https://docs.python.org/es/3.13/library/functions.html#abs

Copy link
Copy Markdown
Contributor

You can see this behavior also in Spanish version https://docs.python.org/es/3.13/library/functions.html#abs

Brazilian Portuguese looks OK, so it is probably just out-of-date source string.

m-aciek commented Feb 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

If someone could double-check that, it'd be great!

Checking with the HEAD of 3.13, there seems to be some new content and some differences. Maybe the code snippets blocks affected the numbers 🤔

Doc % make venv
Doc % make gettext   
python-docs-gr % uv pip install git+https://git.afpy.org/maciek/potodo.git@fix-pot-cli
python-docs-gr % potodo --pot ../cpython/Doc/build/gettext --show-finished
…
- bugs.po                         30 /  31 ( 96.0% translated).
…
# library (5.07% done)
…
- functions.po                   413 / 510 ( 80.0% translated).
…
# tutorial (69.95% done)

- appendix.po                     20 /  28 ( 71.0% translated).
- appetite.po                     17 /  17 (100.0% translated).
- classes.po                     115 / 149 ( 77.0% translated).
- controlflow.po                 155 / 223 ( 69.0% translated).
- datastructures.po               82 / 125 ( 65.0% translated).
- errors.po                       67 /  95 ( 70.0% translated).
- floatingpoint.po                43 /  76 ( 56.0% translated).
- index.po                         8 /   8 (100.0% translated).
- inputoutput.po                  72 / 112 ( 64.0% translated).
- interactive.po                   7 /   7 (100.0% translated).
- interpreter.po                  25 /  33 ( 75.0% translated).
- introduction.po                 76 / 119 ( 63.0% translated).
- modules.po                      88 / 117 ( 75.0% translated).
- stdlib.po                       47 /  67 ( 70.0% translated).
- stdlib2.po                      41 /  65 ( 63.0% translated).
- venv.po                         29 /  42 ( 69.0% translated).
- whatnow.po                      18 /  18 (100.0% translated).
…

For comparison locally looks like 100% indeed:

python-docs-gr % potodo --show-finished --no-cache
…
- bugs.po                         30 /  30 (100.0% translated).
…
- functions.po                   461 / 461 (100.0% translated).
…
# tutorial (100.00% done)

- appendix.po                     20 /  20 (100.0% translated).
- appetite.po                     17 /  17 (100.0% translated).
- classes.po                     119 / 119 (100.0% translated).
- controlflow.po                 164 / 164 (100.0% translated).
- datastructures.po               90 /  90 (100.0% translated).
- errors.po                       69 /  69 (100.0% translated).
- floatingpoint.po                48 /  48 (100.0% translated).
- index.po                         8 /   8 (100.0% translated).
- inputoutput.po                  75 /  75 (100.0% translated).
- interactive.po                   7 /   7 (100.0% translated).
- interpreter.po                  27 /  27 (100.0% translated).
- introduction.po                 79 /  79 (100.0% translated).
- modules.po                      89 /  89 (100.0% translated).
- stdlib.po                       48 /  48 (100.0% translated).
- stdlib2.po                      45 /  45 (100.0% translated).
- venv.po                         30 /  30 (100.0% translated).
- whatnow.po                      18 /  18 (100.0% translated).
…

Copy link
Copy Markdown
Member

Because the iso639 tag for Greek is el, but the more common name is gr, we'd named the repository python-docs-gr. I've added the ability to have an alternative repository name. If people think that's a bad idea, we can always rename the repository as well.

Unhelpfully, there's divergence between ISO 3166-1 alpha-2 and ISO 639-1. Nevertheless, I think we should stick to ISO 639, the standard for classification of languages, for the avoidance of doubt. I hope this doesn't cause too much trouble.

A

Copy link
Copy Markdown

We have completed the necessary updates to successfully publish version 3.12 of python-docs-gr:

  • Update cpython submodule to the latest version.
  • Synced all .po files with the latest translation for 3.12.
  • Applied translation fixes and improvements.

Copy link
Copy Markdown
Member

We have completed the necessary updates to successfully publish version 3.12 of python-docs-gr

Do you have updated numbers for the PEP 545 targets for 3.13 (which is /3/) or 3.13 (/dev/)?

Copy link
Copy Markdown

Do you have updated numbers for the PEP 545 targets for 3.13 (which is /3/) or 3.13 (/dev/)?

For 3.12

# tutorial (100.00% done)

- appendix.po                     24 /  24 (100.0% translated).
- appetite.po                     17 /  17 (100.0% translated).
- classes.po                     149 / 149 (100.0% translated).
- controlflow.po                 223 / 223 (100.0% translated).
- datastructures.po              125 / 125 (100.0% translated).
- errors.po                       95 /  95 (100.0% translated).
- floatingpoint.po                76 /  76 (100.0% translated).
- index.po                         8 /   8 (100.0% translated).
- inputoutput.po                 112 / 112 (100.0% translated).
- interactive.po                   7 /   7 (100.0% translated).
- interpreter.po                  33 /  33 (100.0% translated).
- introduction.po                119 / 119 (100.0% translated).
- modules.po                     117 / 117 (100.0% translated).
- stdlib.po                       67 /  67 (100.0% translated).
- stdlib2.po                      65 /  65 (100.0% translated).
- venv.po                         42 /  42 (100.0% translated).
- whatnow.po                      18 /  18 (100.0% translated).
-----------------------------------------------------------------------------
- functions.po                   497 / 497 (100.0% translated).
-----------------------------------------------------------------------------
- bugs.po                         31 /  31 (100.0% translated).

For 3.13

# tutorial (98.16% done)

- appendix.po                     24 /  28 ( 85.0% translated).
- appetite.po                     17 /  17 (100.0% translated).
- classes.po                     149 / 149 (100.0% translated).
- controlflow.po                 223 / 223 (100.0% translated).
- datastructures.po              125 / 125 (100.0% translated).
- errors.po                       83 /  95 ( 87.0% translated), 12 fuzzy.
- floatingpoint.po                76 /  76 (100.0% translated).
- index.po                         8 /   8 (100.0% translated).
- inputoutput.po                 112 / 112 (100.0% translated).
- interactive.po                   7 /   7 (100.0% translated).
- interpreter.po                  29 /  33 ( 87.0% translated), 4 fuzzy.
- introduction.po                118 / 119 ( 99.0% translated), 1 fuzzy.
- modules.po                     117 / 117 (100.0% translated).
- stdlib.po                       65 /  67 ( 97.0% translated), 2 fuzzy.
- stdlib2.po                      64 /  65 ( 98.0% translated), 1 fuzzy.
- venv.po                         42 /  42 (100.0% translated).
- whatnow.po                      18 /  18 (100.0% translated).
-------------------------------------------------------------------------------------------
- functions.po                   497 / 497 (100.0% translated).
-------------------------------------------------------------------------------------------
- bugs.po                         31 /  31 (100.0% translated).

m-aciek commented Feb 27, 2025

Copy link
Copy Markdown
Contributor

There's a convention to focus on the latest stable Python version. It would be recommended to have a 100% on 3.13 when going live with the switcher. For the time being, we could build the Greek documentation yet without including it in the switcher? (in_prod = false)

AA-Turner changed the title Add Greek translation and allow for alternative repo name Add Greek translation Feb 27, 2025
Comment thread config.toml Outdated

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

Copy link
Copy Markdown
Member Author

Yes, but it's probably best to merge this when the 3.13 docs are ready either way. We also don't have very much time to work on this, so we've been a bit slow with the port.

Comment thread config.toml Outdated

Copy link
Copy Markdown
Member Author

Folks, this can be merged now, I think.

We've had some slow progress lately, but the minimum requirements are now fulfilled for all of 3.12, 3.13 and 3.14.

StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Copy link
Copy Markdown
Member

but the minimum requirements are now fulfilled for all of 3.12, 3.13 and 3.14.

Hmm, we don't actually state in PEP 545 which version should meet the requirements. Something we should probably add in future amendments. cc @JulienPalard / @willingc

Copy link
Copy Markdown
Member

Custom & practice is the current latest minor version, or 'what /3/ points to'.

AA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
  • bugs.html: "If you find a bug in the theme ..." is untranslated.
  • functions.html: 'Built-in' appears untranslated, as do the version* directives, and a few reference titles (e.g. 'asynchronous iterator'). I believe (though unsure) that the last of these requires translating the titles of the relevant source articles, so can probably be overlooked. I think the first two should be addressed before being added to the switcher, though.

I've suggested setting in_prod to false, similarly to the recently merged Romanian translation. This will build on the docsbuild infrastructure, and we can revisit the 545 targets hopefully very soon.

A

Comment thread config.toml
[languages.el]
name = "Greek"
translated_name = "Ελληνικά"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
in_prod = false

skpanagiotis Jun 20, 2025 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We bumped to the latest CPython verion.

  • bugs.html: fixed
  • functions.html: Regarding built-in phrase, it is not untranslated. In some cases throughout the translation project, we intentionally keep the Greek term followed by the English in parentheses. As fo the version* directives I am not entirely sure what the issue is. Some of them render correctly, while others don't.

It's very important for us to publish the translation. This will bring significant benefits such as attracting new contributors, receiving broader feedback and review from end users and motivating current contributors by seeing their work online. 🤗🐍

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
  • As fo the version* directives I am not entirely sure what the issue is.

The source strings still require translation in Sphinx (transifex login required). Happy to add any members of the Greek team as language co-ordinators for Greek in Sphinx.

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you!

AA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Happy to approve with clarification that some of the remaining English terms are intentional. Thank you!

A

AA-Turner merged commit a601ce6 into python:main Jun 20, 2025

AA-Turner commented Jun 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

The translation is now live:

A

Copy link
Copy Markdown
Contributor

Congratulations, Greek team! 👏

Copy link
Copy Markdown
Member

Greek now appears above English in the language switcher, this might annoy people who are used to clicking the first entry, was this intentional?

Copy link
Copy Markdown
Contributor

This might be a consequence of placing languages in the alphabetical order. Should English be an exception and always come first?

StanFromIreland commented Jun 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

This might be a consequence of placing languages in the alphabetical order.

It is because of the current system, which depends on the order they are read from the file I believe, which is a quite interesting way of doing it.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL