Repository navigation
Commit 84271b0
committed
Record ignored errors from non-ignored files
Before this change, fine-grained builds could spuriously mark ignored
legitimate errors as "unused ignores".
By keeping track of these ignored errors we ensure that enough analysis
is done to know that the ignored lines are actually useful.
We have to change is_errors_for_file so that we don't consider files as
faulty when all of their errors were hidden.1 parent cca70fc commit 84271b0
1 file changed
Lines changed: 6 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -503,6 +503,9 @@ def add_error_info(self, info: ErrorInfo) -> None: | |||
| 503 | 503 | self.used_ignored_lines[file][scope_line].append( | |
| 504 | 504 | (info.code or codes.MISC).code | |
| 505 | 505 | ) | |
| 506 | + if file not in self.ignored_files: | ||
| 507 | + info.hidden = True | ||
| 508 | + self._add_error_info(file, info) | ||
| 506 | 509 | return | |
| 507 | 510 | if file in self.ignored_files: | |
| 508 | 511 | return | |
@@ -804,8 +807,9 @@ def blocker_module(self) -> str | None: | |||
| 804 | 807 | return None | |
| 805 | 808 | ||
| 806 | 809 | def is_errors_for_file(self, file: str) -> bool: | |
| 807 | - """Are there any errors for the given file?""" | ||
| 808 | - return file in self.error_info_map | ||
| 810 | + """Are there any visible errors for the given file?""" | ||
| 811 | + errors = self.error_info_map.get(file, ()) | ||
| 812 | + return any(error.hidden is False for error in errors) | ||
| 809 | 813 | ||
| 810 | 814 | def prefer_simple_messages(self) -> bool: | |
| 811 | 815 | """Should we generate simple/fast error messages? | |
0 commit comments