I am planning to make a 0.990 release around late October.
Please post here any issues you'd like to see fixed in the release, or PRs you'd like to have merged. There is no release branch yet - I will update the issue once it exists.
How are we doing on the potential things to fix for next release list? Do all of them have someone working on them?
I'm thinking of cutting a release branch tomorrow. (We can of course add more stuff after)
Cherry picked 5319fa3 (likely addresses performance regression in #13821, no mypy_primer hits, maybe should be solved within mypy rather than in typeshed)
Okay, I've gone ahead and merged #13892 and cherry picked it to release branch. There are probably still some improvements we can make, but the basic checks should catch many user errors and it seems important we include it in the release.
Unfortunately we'll have to postpone the release by 2-3 days. Jukka found that mypy crashes if except* is used in python 3.11 (https://peps.python.org/pep-0654/). The thinking is to make it at least not crash so we can announce the start of (basic) support for 3.11 in this release. This way maybe we can get some testing until 1.0.0 version.
Reacted by Marti Raudsepp, Emma Smith, Robin Tweedie and Alex Waygood
@svalentin I think treating except* exactly like except is pretty viable for "make it not crash". Opened #13991 for this
#12840 contains two other language changes that we should add tests for to make sure mypy can handle (but they're not headline features, so it's not as important and they likely won't crash mypy)
Is there any chance of getting a patch release with #14077 included? #14030 was experienced as quite a bad regression for heavy users of the stdlib ast module (though typeshed is at least partly to blame for the regression 🙂)
I don't like this idea. It is not a regression, some people may actually like semantics in 0.990. Point releases are for bad obvious bugs (and crashes).
I don't like this idea. It is not a regression, some people may actually like semantics in 0.990. Point releases are for bad obvious bugs (and crashes).
If we merged the changes to the ast stubs as suggested in python/typeshed#9130, would you be open to cherry-picking those changes into the patch release?
Activity
hauntsaninja commented on Oct 11, 2022
Possible things to fix:
cdce8p commented on Oct 12, 2022
It would be awesome if these PRs could be included. The first one is already approved
ilevkivskyi commented on Oct 13, 2022
@sobolevn IIUC you are working on LiteralString, right? Will you have time to finish it in time for 0.990?
sobolevn commented on Oct 13, 2022
Yes, I will :)
svalentin commented on Oct 18, 2022
How are we doing on the potential things to fix for next release list? Do all of them have someone working on them?
I'm thinking of cutting a release branch tomorrow. (We can of course add more stuff after)
svalentin commented on Oct 27, 2022
Sorry got carried away. Will make the release branch today!
Looking to release this around Tuesday unless there's any pressing issues.
svalentin commented on Oct 27, 2022
Created origin/release-0.990 at ec6d9d9
hauntsaninja commented on Oct 27, 2022
Cherry picked 2d70ac0 (useful for typeshed, no user visible changes)
hauntsaninja commented on Oct 29, 2022
Cherry picked 5319fa3 (likely addresses performance regression in #13821, no mypy_primer hits, maybe should be solved within mypy rather than in typeshed)
hauntsaninja commented on Oct 30, 2022
I think it would be very good (but not necessarily blocking) to get in #13892 cc @JukkaL @sobolevn
False negatives related to #13890 / #13472 show up pretty often (e.g. we just got another report in #13966, where things would silently not work)
Edit: I've now merged this in and cherry picked to release branch
sobolevn commented on Oct 30, 2022
Yes, reporing invalid ParamSpec usage seems quite important.
hauntsaninja commented on Oct 30, 2022
Okay, I've gone ahead and merged #13892 and cherry picked it to release branch. There are probably still some improvements we can make, but the basic checks should catch many user errors and it seems important we include it in the release.
svalentin commented on Nov 2, 2022
Unfortunately we'll have to postpone the release by 2-3 days. Jukka found that mypy crashes if except* is used in python 3.11 (https://peps.python.org/pep-0654/). The thinking is to make it at least not crash so we can announce the start of (basic) support for 3.11 in this release. This way maybe we can get some testing until 1.0.0 version.
sobolevn commented on Nov 2, 2022
Ok, I think I won't be able to finish LiteralString support in this release, there's a lot going on right now.
And I don't want to rush it.
Looks like we will have to move it to the next release. Sorry!
hauntsaninja commented on Nov 2, 2022
@svalentin I think treating except* exactly like except is pretty viable for "make it not crash". Opened #13991 for this
#12840 contains two other language changes that we should add tests for to make sure mypy can handle (but they're not headline features, so it's not as important and they likely won't crash mypy)
16 remaining items
svalentin commented on Nov 10, 2022
Yes! #14060 and #14038 are already CPed in the release-0.990 branch. Waiting for the other 3.
hauntsaninja commented on Nov 11, 2022
Made PRs for the other three issues!
ilevkivskyi commented on Nov 11, 2022
Merged two out of three, and left feedback for the third one.
hauntsaninja commented on Nov 11, 2022
Thanks! All are merged now, just cherry picked to release-0.990 branch
svalentin commented on Nov 11, 2022
Thanks! I'll go through the release formalities on Monday
AlexWaygood commented on Nov 14, 2022
Is there any chance of getting a patch release with #14077 included? #14030 was experienced as quite a bad regression for heavy users of the stdlib ast module (though typeshed is at least partly to blame for the regression 🙂)
ilevkivskyi commented on Nov 14, 2022
I don't like this idea. It is not a regression, some people may actually like semantics in 0.990. Point releases are for bad obvious bugs (and crashes).
AlexWaygood commented on Nov 14, 2022
If we merged the changes to the ast stubs as suggested in python/typeshed#9130, would you be open to cherry-picking those changes into the patch release?
ilevkivskyi commented on Nov 14, 2022
Yes, this is a safer option, unless someone else is against.
AlexWaygood commented on Nov 14, 2022
Okay, I merged the typeshed change. It would be great if python/typeshed@f9cd5ee could be cherry-picked to the patch release :)
svalentin commented on Nov 14, 2022
I manually included python/typeshed@f9cd5ee into the release branch - the commit 6077d19
AlexWaygood commented on Nov 14, 2022
Thanks so much @svalentin!
svalentin commented on Nov 14, 2022
v0.991 wheels should be on pypi now!
svalentin commented on Nov 14, 2022
Marking this as Done!
Will reopen if we need another point release.