The fact that it only affects 3.7 made me search why. Looks like it has been done in 10be089, so now we "just" need to understand why it's not applied in 3.7.
Feel free to take a look at it, but maybe as the python-docs-theme is not pinned in docsbuild scripts nor in cpython, it just never updated, I'll probably have to check it myself on the server, hope I'll have time soon.
Uhhhhh. I'm not a huge fan of the patch from #25 -- the specific styling for this element comes from the pygments theme, which means that the fix is a bit of a bodge.
That said, I don't see the issue in 3.7's docs anymore and this can be closed IMO.
Oh, answer is simple, python-docs-theme was not separated in 3.7. And 3.7 is in security only, better keep things untouched. Bug is fixed for >=3.8, which is good enough.
Activity
shivankgtm commented on Feb 13, 2020
This issue seems to be with docs of python3.7 only. can I take this issue to solve?
JulienPalard commented on Feb 13, 2020
The fact that it only affects 3.7 made me search why. Looks like it has been done in 10be089, so now we "just" need to understand why it's not applied in 3.7.
Feel free to take a look at it, but maybe as the python-docs-theme is not pinned in docsbuild scripts nor in cpython, it just never updated, I'll probably have to check it myself on the server, hope I'll have time soon.
pradyunsg commented on Nov 13, 2020
Uhhhhh. I'm not a huge fan of the patch from #25 -- the specific styling for this element comes from the pygments theme, which means that the fix is a bit of a bodge.
That said, I don't see the issue in 3.7's docs anymore and this can be closed IMO.
JulienPalard commented on Nov 15, 2020
I still see it in 3.7 where it looks like an empty string:
vs 3.8 were I clearly see it's a space:
JulienPalard commented on Nov 15, 2020
python-docs-theme is not pinned, so the venv on the build server is probably just old, I'll check this.
Looks like all venvs use python-docs-theme==2020.1, I'll check styles in production to try to pinpoint the difference.
JulienPalard commented on Nov 15, 2020
Oh, answer is simple, python-docs-theme was not separated in 3.7. And 3.7 is in security only, better keep things untouched. Bug is fixed for >=3.8, which is good enough.
pradyunsg commented on Nov 15, 2020
Awesome! Thanks for looking @JulienPalard! ^.^