Tighten annotation of logging.getLevelName (#12088) · python/typeshed@97ccd89 · GitHub

python / typeshed Public

• Notifications You must be signed in to change notification settings
• Fork 2.1k
• Star 5.1k

• Code
• Issues 212
• Pull requests 167
• Actions
• Security and quality
• Insights

Additional navigation options

Commit 97ccd89

Browse filesBrowse the repository at this point in the historyBrowse files

cjwatson

authored

Tighten annotation of logging.getLevelName (#12088)

To better reflect the implementation's behaviour, #2730 changed `logging.getLevelName` to accept `int | str` and return `Any` (the latter due to the need to avoid union return types). However, this isn't ideal if you're passing in an `int`, in which case the implementation always returns a `str`. Add overloads for this.

1 parent 6ddf464 commit 97ccd89
Copy full SHA for 97ccd89

1 file changed

+8-1Lines changed: 8 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• stdlib/logging
  • __init__.pyi

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎stdlib/logging/__init__.pyi‎

Copy file name to clipboardExpand all lines: stdlib/logging/__init__.pyi

+8-1Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -572,7 +572,14 @@ fatal = critical
572	572
573	573	def disable(level: int = 50) -> None: ...
574	574	def addLevelName(level: int, levelName: str) -> None: ...
575		- def getLevelName(level: _Level) -> Any: ...
	575	+ @overload
	576	+ def getLevelName(level: int) -> str: ...
	577	+
	578	+ # The str -> int case is considered a mistake, but retained for backward
	579	+ # compatibility. See
	580	+ # https://docs.python.org/3/library/logging.html#logging.getLevelName.
	581	+ @overload
	582	+ def getLevelName(level: str) -> Any: ...
576	583
577	584	if sys.version_info >= (3, 11):
578	585	def getLevelNamesMapping() -> dict[str, int]: ...

0 commit comments

Comments

0 (0)