FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Comparing main...pr/1916 · python/typing · GitHub

/ typing Public
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: python/typing
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
Could not load branches
Nothing to show
{{ refName }}
...
head repository: python/typing
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: pr/1916
Choose a head ref
Could not load branches
Nothing to show
{{ refName }}
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 9 files changed
  • 2 contributors

Commits on Jan 31, 2025

  1. Add conformance test for @final-decorated @Property 

    The language of the typing spec indicates that the @Final decorator
may be used with properties:

> The method decorator version may be used with all of instance methods, class methods, static methods, and properties.

I noticed this case while working on Pyre. I observed that Mypy and
Pyright also differ in behavior, so it seemed like a good conformance
test to add.

See discussion here:
https://discuss.python.org/t/proposal-allow-chaining-final-decorator-when-previous-decorators-return-a-non-function/78918
    samwgoldman committed Jan 31, 2025
    Configuration menu
    Copy the full SHA
    52aad76 View commit details
    Browse the repository at this point in the history

  2. Add example of @Final with @Property to the typing spec 

    I thought it would be nice to add an example showing the use of @Final
and @Property together, but I also think the existing content is
reasonably clear that this example is supposed to work.
    samwgoldman committed Jan 31, 2025
    Configuration menu
    Copy the full SHA
    06ce4cc View commit details
    Browse the repository at this point in the history

  3. Update conformance result for pyright/qualifiers_final_decorator.toml

    samwgoldman committed Jan 31, 2025
    Configuration menu
    Copy the full SHA
    f4d1db6 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2026

  1. Merge remote-tracking branch 'upstream/main' into codex/pr-1916-merge… 

    …-main

# Conflicts:
#	conformance/results/mypy/version.toml
#	conformance/results/pyre/qualifiers_final_decorator.toml
#	conformance/results/pyre/version.toml
#	conformance/results/pyright/qualifiers_annotated.toml
#	conformance/results/pyright/qualifiers_final_decorator.toml
#	conformance/results/pyright/version.toml
#	conformance/results/pytype/qualifiers_final_decorator.toml
#	conformance/results/pytype/version.toml
#	conformance/results/results.html
    JelleZijlstra committed Aug 7, 2026
    Configuration menu
    Copy the full SHA
    b6d56e3 View commit details
    Browse the repository at this point in the history

  2. align wording

    JelleZijlstra committed Aug 7, 2026
    Configuration menu
    Copy the full SHA
    e49ef3b View commit details
    Browse the repository at this point in the history
Loading
Back | FazBrowse Home | New Git URL