Repository navigation
Spec: Final section could use better definition for Final vs. Final[X] #2356
Description
Came up in #2353: Currently, the syntax section for Final uses the following definitions:
Final may be used in one of several forms:
- With an explicit type, using the syntax Final[<type>] [...]
- With no type annotation. [...]
As @carljm points out, these definitions are not great. I suggest to give them better names and use those consistently in the spec (and elsewhere). Carl used "bare" for the latter case, which I like. Maybe "explicitly typed" for the former? "When using a bare Final ..." or "When using an explicitly typed Final ..."
Activity
jorenham commented on Sep 2, 2026
"implicit" might also be an option
JelleZijlstra commented on Sep 2, 2026
I like the term "bare"; "implicit" I would read as treating things as Final when there is no use of the Final qualifier. I believe pyright does that for all-uppercase constants.
pavithraramesh5500-ship-cse commented on Oct 19, 2026
Hi, I'd like to work on this issue as my second open-source contribution. I plan to reproduce the bug, implement the fix, and add a regression test. Please let me know if this is available to work on.
jorenham commented on Oct 19, 2026
@pavithraramesh5500-ship-cse this isn't a well suited for beginners as it requires in-depth expertise of Python's type system
pavithraramesh5500-ship-cse commented on Oct 19, 2026
Let give me a chance I'll do my best
jorenham commented on Oct 19, 2026
no
pavithraramesh5500-ship-cse commented on Oct 19, 2026
Thank you for your feedback! I understand that this issue requires a deeper understanding of Python's type system. However, I'm really eager to learn and contribute to open source. I would be grateful if you could give me a chance to work on this issue under your guidance. I'm ready to put in the effort, learn what is required, and make the necessary improvements. I may be a beginner, but I'm willing to learn and give my best. I hope you'll consider giving me this opportunity. Thank you! 😊
JelleZijlstra commented on Oct 19, 2026
This kind of change requires a deep understanding of behavior across the type system and the ability to coordinate and find consensus among many tools. It's not well-suited for someone without much experience in the area.
If you're interested in starting to contribute to the open-source Python typing ecosystem, I'd recommend starting with contributing to https://github.com/python/typeshed.
pavithraramesh5500-ship-cse commented on Oct 19, 2026
Thank you for your honest feedback and for suggesting Typeshed. I understand that this change requires more experience, and I'm willing to learn and improve my skills. I'm a beginner, but I'm genuinely interested in contributing to Python's open-source ecosystem. If possible, could you please guide me toward a small task where I can start learning and prove my abilities? I'd be grateful for the opportunity to contribute and grow through this experience. Thank you!