FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lookup __reversed__ correctly as a special method · python-emscripten/cpython@809e225 · GitHub

Repository navigation

Commit 809e225

Browse files
committed
lookup __reversed__ correctly as a special method
1 parent 84ad84e commit 809e225

2 files changed

Lines changed: 11 additions & 3 deletions

File tree

‎Lib/test/test_descr.py‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1676,12 +1676,15 @@ def iden(self):
16761676
return self
16771677
def hello(self):
16781678
return "hello"
1679+
def empty_seq(self):
1680+
return []
16791681

16801682
# It would be nice to have every special method tested here, but I'm
16811683
# only listing the ones I can remember outside of typeobject.c, since it
16821684
# does it right.
16831685
specials = [
16841686
("__unicode__", unicode, hello),
1687+
("__reversed__", reversed, empty_seq),
16851688
# These two fail because the compiler generates LOAD_ATTR to look
16861689
# them up. We'd have to add a new opcode to fix this, and it's
16871690
# probably not worth it.

‎Objects/enumobject.c‎

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,8 @@ static PyObject *
222222
reversed_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
223223
{
224224
Py_ssize_t n;
225-
PyObject *seq;
225+
PyObject *seq, *reversed_meth;
226+
static PyObject *reversed_cache = NULL;
226227
reversedobject *ro;
227228

228229
if (type == &PyReversed_Type && !_PyArg_NoKeywords("reversed()", kwds))
@@ -231,8 +232,12 @@ reversed_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
231232
if (!PyArg_UnpackTuple(args, "reversed", 1, 1, &seq) )
232233
return NULL;
233234

234-
if (PyObject_HasAttrString(seq, "__reversed__"))
235-
return PyObject_CallMethod(seq, "__reversed__", NULL);
235+
reversed_meth = _PyObject_LookupSpecial(seq, "__reversed__", &reversed_cache);
236+
if (reversed_meth != NULL) {
237+
PyObject *res = PyObject_CallFunctionObjArgs(reversed_meth, NULL);
238+
Py_DECREF(reversed_meth);
239+
return res;
240+
}
236241

237242
if (!PySequence_Check(seq)) {
238243
PyErr_SetString(PyExc_TypeError,

0 commit comments

Comments
 (0)

Back | FazBrowse Home | New Git URL