Issue #9566: Fix a compiler warning on Windows 64-bit in namespace_in… · python-emscripten/cpython@9d77664 · GitHub

1. python-emscripten
2. cpython

Repository navigation

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Commit 9d77664

Browse filesBrowse the repository at this point in the historyBrowse files

vstinner

committed

Issue python#9566: Fix a compiler warning on Windows 64-bit in namespace_init()

The result type is int, return -1 to avoid a compiler warning (cast Py_ssize_t to int). PyObject_Size() can only fail with -1, and anyway a constructor should return -1 on error, not an arbitrary negative number.

1 parent a2d5698 commit 9d77664
Copy full SHA for 9d77664

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• Objects
  • namespaceobject.c

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎Objects/namespaceobject.c‎

Copy file name to clipboardExpand all lines: Objects/namespaceobject.c

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -44,7 +44,7 @@ namespace_init(_PyNamespaceObject *ns, PyObject *args, PyObject *kwds)
44	44	if (args != NULL) {
45	45	Py_ssize_t argcount = PyObject_Size(args);
46	46	if (argcount < 0)
47		- return argcount;
	47	+ return -1;
48	48	else if (argcount > 0) {
49	49	PyErr_Format(PyExc_TypeError, "no positional arguments expected");
50	50	return -1;

0 commit comments

Comments

0 (0)