Commit e348c8d
committed
Using 'long double' to force this structure to be worst case aligned is no
longer required as of Python 2.5+ when the gc_refs changed from an int (4
bytes) to a Py_ssize_t (8 bytes) as the minimum size is 16 bytes.
The use of a 'long double' triggered a warning by Clang trunk's
Undefined-Behavior Sanitizer as on many platforms a long double requires
16-byte alignment but the Python memory allocator only guarantees 8 byte
alignment.
So our code would allocate and use these structures with technically improper
alignment. Though it didn't matter since the 'dummy' field is never used.
This silences that warning.
Spelunking into code history, the double was added in 2001 to force better
alignment on some platforms and changed to a long double in 2002 to appease
Tru64. That issue should no loner be present since the upgrade from int to
Py_ssize_t where the minimum structure size increased to 16 (unless anyone
knows of a platform where ssize_t is 4 bytes?) or 24 bytes depending on if the
build uses 4 or 8 byte pointers.
We can probably get rid of the double and this union hack all together today.
That is a slightly more invasive change that can be left for later.
A more correct non-hacky alternative if any alignment issues are still found
would be to use a compiler specific alignment declaration on the structure and
determine which value to use at configure time.1 parent 60112ae commit e348c8d
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -251,7 +251,7 @@ typedef union _gc_head { | |||
| 251 | 251 | union _gc_head *gc_prev; | |
| 252 | 252 | Py_ssize_t gc_refs; | |
| 253 | 253 | } gc; | |
| 254 | - long double dummy; /* force worst-case alignment */ | ||
| 254 | + double dummy; /* force worst-case alignment */ | ||
| 255 | 255 | } PyGC_Head; | |
| 256 | 256 | ||
| 257 | 257 | extern PyGC_Head *_PyGC_generation0; | |
0 commit comments