fix(client): retry fetching server version after an unknown result · python-gitlab/python-gitlab@046fbac · GitHub

1. python-gitlab
2. python-gitlab

Repository navigation

• Code
• Issues16 (16)
• Pull requests15 (15)
• Discussions
• Actions
• Projects
• Security and quality
• Insights

Commit 046fbac

Browse filesBrowse the repository at this point in the historyBrowse files

maretodoric

authored and

JohnVillalovos

committed

fix(client): retry fetching server version after an unknown result

Previously, once `version()` failed to retrieve the server version and cached "unknown" for `_server_version`/`_server_revision`, all subsequent calls would short-circuit on the `is None` check and keep returning the cached "unknown" values forever, even if the server was reachable again. Now `version()` also retries when the cached value is "unknown".

1 parent 72134f5 commit 046fbac
Copy full SHA for 046fbac

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• gitlab
  • client.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎gitlab/client.py‎

Copy file name to clipboardExpand all lines: gitlab/client.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -404,7 +404,7 @@ def version(self) -> tuple[str, str]:
404	404	The server version and server revision.
405	405	('unknown', 'unknown') if the server doesn't perform as expected.
406	406	"""
407		- if self._server_version is None:
	407	+ if self._server_version in (None, "unknown"):
408	408	try:
409	409	data = self.http_get("/version")
410	410	if isinstance(data, dict):

0 commit comments

Comments

0 (0)