Repository navigation
Commit 15a242c
committed
fix(cli): project-merge-request-approval-rule
Using the CLI the command:
gitlab project-merge-request-approval-rule list --mr-iid 1 --project-id foo/bar
Would raise an exception. This was due to the fact that `_id_attr` and
`_repr_attr` were set for keys which are not returned in the response.
Add a unit test which shows the `repr` function now works. Before it
did not.
This is an EE feature so we can't functional test it.
Closes: #20651 parent ae7d3b0 commit 15a242c
2 files changed
Lines changed: 2 additions & 2 deletions
File tree
- gitlab/v4/objects
- tests/unit/objects
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -165,8 +165,7 @@ def set_approvers( | |||
| 165 | 165 | ||
| 166 | 166 | ||
| 167 | 167 | class ProjectMergeRequestApprovalRule(SaveMixin, ObjectDeleteMixin, RESTObject): | |
| 168 | - _id_attr = "approval_rule_id" | ||
| 169 | - _repr_attr = "approval_rule" | ||
| 168 | + _repr_attr = "name" | ||
| 170 | 169 | id: int | |
| 171 | 170 | approval_rule_id: int | |
| 172 | 171 | merge_request_iid: int | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -168,6 +168,7 @@ def test_list_merge_request_approval_rules(project, resp_mr_approval_rules): | |||
| 168 | 168 | assert len(approval_rules) == 1 | |
| 169 | 169 | assert approval_rules[0].name == approval_rule_name | |
| 170 | 170 | assert approval_rules[0].id == approval_rule_id | |
| 171 | + repr(approval_rules) # ensure that `repr()` doesn't raise an exception | ||
| 171 | 172 | ||
| 172 | 173 | ||
| 173 | 174 | def test_delete_merge_request_approval_rule(project, resp_delete_mr_approval_rule): | |
0 commit comments