Repository navigation
Commit 1e89164
committed
chore: enable pylint checks
Enable the pylint checks:
* unnecessary-pass
* unspecified-encoding
Update code to resolve errors found1 parent 6cdccd9 commit 1e89164
3 files changed
Lines changed: 1 addition & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -263,7 +263,7 @@ def _parse_value(v: Any) -> Any: | |||
| 263 | 263 | # If the user-provided value starts with @, we try to read the file | |
| 264 | 264 | # path provided after @ as the real value. Exit on any error. | |
| 265 | 265 | try: | |
| 266 | - with open(v[1:]) as f: | ||
| 266 | + with open(v[1:], encoding="utf-8") as f: | ||
| 267 | 267 | return f.read() | |
| 268 | 268 | except Exception as e: | |
| 269 | 269 | sys.stderr.write(f"{e}\n") | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -244,8 +244,6 @@ class RetrieveMixin(ListMixin, GetMixin): | |||
| 244 | 244 | _path: Optional[str] | |
| 245 | 245 | gitlab: gitlab.Gitlab | |
| 246 | 246 | ||
| 247 | - pass | ||
| 248 | - | ||
| 249 | 247 | ||
| 250 | 248 | class CreateMixin(_RestManagerBase): | |
| 251 | 249 | _computed_path: Optional[str] | |
@@ -429,8 +427,6 @@ class CRUDMixin(GetMixin, ListMixin, CreateMixin, UpdateMixin, DeleteMixin): | |||
| 429 | 427 | _path: Optional[str] | |
| 430 | 428 | gitlab: gitlab.Gitlab | |
| 431 | 429 | ||
| 432 | - pass | ||
| 433 | - | ||
| 434 | 430 | ||
| 435 | 431 | class NoUpdateMixin(GetMixin, ListMixin, CreateMixin, DeleteMixin): | |
| 436 | 432 | _computed_path: Optional[str] | |
@@ -441,8 +437,6 @@ class NoUpdateMixin(GetMixin, ListMixin, CreateMixin, DeleteMixin): | |||
| 441 | 437 | _path: Optional[str] | |
| 442 | 438 | gitlab: gitlab.Gitlab | |
| 443 | 439 | ||
| 444 | - pass | ||
| 445 | - | ||
| 446 | 440 | ||
| 447 | 441 | class SaveMixin(_RestObjectBase): | |
| 448 | 442 | """Mixin for RESTObject's that can be updated.""" | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -78,8 +78,6 @@ disable = [ | |||
| 78 | 78 | "too-many-locals", | |
| 79 | 79 | "too-many-statements", | |
| 80 | 80 | "unexpected-keyword-arg", | |
| 81 | - "unnecessary-pass", | ||
| 82 | - "unspecified-encoding", | ||
| 83 | 81 | "unsubscriptable-object", | |
| 84 | 82 | "unused-argument", | |
| 85 | 83 | "useless-import-alias", | |
0 commit comments