Merge pull request #2173 from python-gitlab/jlvillal/config_test_fix · python-gitlab/python-gitlab@1ecbc7c · GitHub

1. python-gitlab
2. python-gitlab

Repository navigation

• Code
• Issues16 (16)
• Pull requests15 (15)
• Discussions
• Actions
• Projects
• Security and quality
• Insights

Commit 1ecbc7c

Browse filesBrowse the repository at this point in the historyBrowse files

nejch

authored

Merge pull request #2173 from python-gitlab/jlvillal/config_test_fix

test: fix broken test if user had config files

2 parents 7afd340 + 864fc12 commit 1ecbc7c
Copy full SHA for 1ecbc7c

1 file changed

+6-1Lines changed: 6 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• tests/unit
  • test_gitlab.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎tests/unit/test_gitlab.py‎

Copy file name to clipboardExpand all lines: tests/unit/test_gitlab.py

+6-1Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -20,6 +20,7 @@
20	20	import logging
21	21	import pickle
22	22	from http.client import HTTPConnection
	23	+ from typing import List, Optional, Union
23	24
24	25	import pytest
25	26	import responses
@@ -300,7 +301,11 @@ def test_gitlab_from_config(default_config):
300	301	gitlab.Gitlab.from_config("one", [config_path])
301	302
302	303
303		- def test_gitlab_from_config_without_files_raises():
	304	+ def test_gitlab_from_config_without_files_raises(monkeypatch):
	305	+ def no_files(config_files: Optional[List[str]] = None) -> Union[str, List[str]]:
	306	+ return []
	307	+
	308	+ monkeypatch.setattr(gitlab.config, "_get_config_files", no_files)
304	309	with pytest.raises(GitlabConfigMissingError, match="non-existing"):
305	310	gitlab.Gitlab.from_config("non-existing")
306	311

0 commit comments

Comments

0 (0)