feat(api): remove responsibility for API inconsistencies for MR revie… · python-gitlab/python-gitlab@3d985ee · GitHub

1. python-gitlab
2. python-gitlab

Repository navigation

• Code
• Issues16 (16)
• Pull requests15 (15)
• Discussions
• Actions
• Projects
• Security and quality
• Insights

Commit 3d985ee

Browse filesBrowse the repository at this point in the historyBrowse files

spyoungtech

authored

feat(api): remove responsibility for API inconsistencies for MR reviewers

1 parent 676d1f6 commit 3d985ee
Copy full SHA for 3d985ee

1 file changed

-16Lines changed: 0 additions & 16 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• gitlab/v4/objects
  • merge_requests.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎gitlab/v4/objects/merge_requests.py‎

Copy file name to clipboardExpand all lines: gitlab/v4/objects/merge_requests.py

-16Lines changed: 0 additions & 16 deletions

Original file line number	Diff line number	Diff line change
@@ -138,22 +138,6 @@ class ProjectMergeRequest(
138	138	):
139	139	_id_attr = "iid"
140	140
141		- @property
142		- def reviewer_ids(self):
143		- return [reviewer["id"] for reviewer in self.reviewers]
144		-
145		- @reviewer_ids.setter
146		- def reviewer_ids(self, new_reviewer_ids):
147		- new_reviewers = [{"id": id} for id in set(new_reviewer_ids)]
148		- new_reviewers.extend(
149		- [
150		- reviewer
151		- for reviewer in self.reviewers
152		- if reviewer["id"] in new_reviewer_ids
153		- ]
154		- )
155		- self.reviewers = new_reviewers
156		-
157	141	_managers = (
158	142	("approvals", "ProjectMergeRequestApprovalManager"),
159	143	("approval_rules", "ProjectMergeRequestApprovalRuleManager"),

0 commit comments

Comments

0 (0)