refactor(objects): remove deprecated constants defined in objects · python-gitlab/python-gitlab@3f320af · GitHub

1. python-gitlab
2. python-gitlab

Repository navigation

• Code
• Issues16 (16)
• Pull requests15 (15)
• Discussions
• Actions
• Projects
• Security and quality
• Insights

Commit 3f320af

Browse filesBrowse the repository at this point in the historyBrowse files

nejch

authored and

JohnVillalovos

committed

refactor(objects): remove deprecated constants defined in objects

BREAKING CHANGE: remove deprecated constants defined in gitlab.v4.objects, and use only gitlab.const module

1 parent 2b8a94a commit 3f320af
Copy full SHA for 3f320af

3 files changed

+4-16Lines changed: 4 additions & 16 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• gitlab
  • const.py
  • v4/objects
    • __init__.py
• tests/functional/api
  • test_snippets.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎gitlab/const.py‎

Copy file name to clipboardExpand all lines: gitlab/const.py

+3-4Lines changed: 3 additions & 4 deletions

Original file line number	Diff line number	Diff line change
@@ -25,12 +25,11 @@
25	25	REPORTER_ACCESS: int = 20
26	26	DEVELOPER_ACCESS: int = 30
27	27	MAINTAINER_ACCESS: int = 40
28		- MASTER_ACCESS: int = MAINTAINER_ACCESS
29	28	OWNER_ACCESS: int = 50
30	29
31		- VISIBILITY_PRIVATE: int = 0
32		- VISIBILITY_INTERNAL: int = 10
33		- VISIBILITY_PUBLIC: int = 20
	30	+ VISIBILITY_PRIVATE: str = "private"
	31	+ VISIBILITY_INTERNAL: str = "internal"
	32	+ VISIBILITY_PUBLIC: str = "public"
34	33
35	34	NOTIFICATION_LEVEL_DISABLED: str = "disabled"
36	35	NOTIFICATION_LEVEL_PARTICIPATING: str = "participating"

Collapse file

‎gitlab/v4/objects/__init__.py‎

Copy file name to clipboardExpand all lines: gitlab/v4/objects/__init__.py

-11Lines changed: 0 additions & 11 deletions

Original file line number	Diff line number	Diff line change
@@ -74,15 +74,4 @@
74	74	from .variables import *
75	75	from .wikis import *
76	76
77		- # TODO: deprecate these in favor of gitlab.const.*
78		- VISIBILITY_PRIVATE = "private"
79		- VISIBILITY_INTERNAL = "internal"
80		- VISIBILITY_PUBLIC = "public"
81		-
82		- ACCESS_GUEST = 10
83		- ACCESS_REPORTER = 20
84		- ACCESS_DEVELOPER = 30
85		- ACCESS_MASTER = 40
86		- ACCESS_OWNER = 50
87		-
88	77	__all__ = [name for name in dir() if not name.startswith("_")]

Collapse file

‎tests/functional/api/test_snippets.py‎

Copy file name to clipboardExpand all lines: tests/functional/api/test_snippets.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -33,7 +33,7 @@ def test_project_snippets(project):
33	33	"title": "snip1",
34	34	"file_name": "foo.py",
35	35	"content": "initial content",
36		- "visibility": gitlab.v4.objects.VISIBILITY_PRIVATE,
	36	+ "visibility": gitlab.VISIBILITY_PRIVATE,
37	37	}
38	38	)
39	39

0 commit comments

Comments

0 (0)