Repository navigation
Commit 5b642a5
chore: add basic type checks to functional/api tests
1 parent ee143c9 commit 5b642a5
5 files changed
Lines changed: 7 additions & 6 deletions
File tree
- tests/functional/api
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -8,18 +8,19 @@ files = "." | |||
| 8 | 8 | exclude = "build/.*" | |
| 9 | 9 | strict = true | |
| 10 | 10 | ||
| 11 | - [[tool.mypy.overrides]] # Overrides for currently untyped modules | ||
| 11 | + # Overrides for currently untyped modules | ||
| 12 | + [[tool.mypy.overrides]] | ||
| 12 | 13 | module = [ | |
| 13 | 14 | "docs.*", | |
| 14 | 15 | "docs.ext.*", | |
| 15 | - "tests.functional.api.*", | ||
| 16 | 16 | "tests.unit.*", | |
| 17 | 17 | ] | |
| 18 | 18 | ignore_errors = true | |
| 19 | 19 | ||
| 20 | 20 | [[tool.mypy.overrides]] | |
| 21 | 21 | module = [ | |
| 22 | 22 | "tests.functional.*", | |
| 23 | + "tests.functional.api.*", | ||
| 23 | 24 | "tests.meta.*", | |
| 24 | 25 | "tests.smoke.*", | |
| 25 | 26 | ] | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -45,7 +45,7 @@ def test_project_import_export(gl, project, temp_dir): | |||
| 45 | 45 | raise Exception("Project export taking too much time") | |
| 46 | 46 | ||
| 47 | 47 | with open(temp_dir / "gitlab-export.tgz", "wb") as f: | |
| 48 | - export.download(streamed=True, action=f.write) | ||
| 48 | + export.download(streamed=True, action=f.write) # type: ignore[arg-type] | ||
| 49 | 49 | ||
| 50 | 50 | output = gl.projects.import_project( | |
| 51 | 51 | open(temp_dir / "gitlab-export.tgz", "rb"), | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -6,7 +6,7 @@ | |||
| 6 | 6 | import hashlib | |
| 7 | 7 | ||
| 8 | 8 | ||
| 9 | - def key_fingerprint(key): | ||
| 9 | + def key_fingerprint(key: str) -> str: | ||
| 10 | 10 | key_part = key.split()[1] | |
| 11 | 11 | decoded = base64.b64decode(key_part.encode("ascii")) | |
| 12 | 12 | digest = hashlib.sha256(decoded).digest() | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -177,7 +177,7 @@ def test_merge_request_reset_approvals(gitlab_url, project, wait_for_sidekiq): | |||
| 177 | 177 | bot_project = bot_gitlab.projects.get(project.id, lazy=True) | |
| 178 | 178 | ||
| 179 | 179 | wait_for_sidekiq(timeout=60) | |
| 180 | - mr = bot_project.mergerequests.list()[0] | ||
| 180 | + mr = bot_project.mergerequests.list()[0] # type: ignore[index] | ||
| 181 | 181 | assert mr.reset_approvals() | |
| 182 | 182 | ||
| 183 | 183 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -142,7 +142,7 @@ def test_project_forks(gl, project, user): | |||
| 142 | 142 | assert fork_project.forked_from_project["id"] == project.id | |
| 143 | 143 | ||
| 144 | 144 | forks = project.forks.list() | |
| 145 | - assert fork.id in map(lambda fork_project: fork_project.id, forks) | ||
| 145 | + assert fork.id in [fork_project.id for fork_project in forks] | ||
| 146 | 146 | ||
| 147 | 147 | ||
| 148 | 148 | def test_project_hooks(project): | |
0 commit comments