Repository navigation
Commit 64b208e
committed
chore: enable mypy check no_implicit_optional
1 parent 54dd4c3 commit 64b208e
4 files changed
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -38,7 +38,7 @@ class ApplicationAppearanceManager(GetWithoutIdMixin, UpdateMixin, RESTManager): | |||
| 38 | 38 | def update( | |
| 39 | 39 | self, | |
| 40 | 40 | id: Optional[Union[str, int]] = None, | |
| 41 | - new_data: Dict[str, Any] = None, | ||
| 41 | + new_data: Optional[Dict[str, Any]] = None, | ||
| 42 | 42 | **kwargs: Any | |
| 43 | 43 | ) -> Dict[str, Any]: | |
| 44 | 44 | """Update an object on the server. | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -196,7 +196,7 @@ def repository_contributors( | |||
| 196 | 196 | @exc.on_http_error(exc.GitlabListError) | |
| 197 | 197 | def repository_archive( | |
| 198 | 198 | self, | |
| 199 | - sha: str = None, | ||
| 199 | + sha: Optional[str] = None, | ||
| 200 | 200 | streamed: bool = False, | |
| 201 | 201 | action: Optional[Callable[..., Any]] = None, | |
| 202 | 202 | chunk_size: int = 1024, | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -93,7 +93,7 @@ class ApplicationSettingsManager(GetWithoutIdMixin, UpdateMixin, RESTManager): | |||
| 93 | 93 | def update( | |
| 94 | 94 | self, | |
| 95 | 95 | id: Optional[Union[str, int]] = None, | |
| 96 | - new_data: Dict[str, Any] = None, | ||
| 96 | + new_data: Optional[Dict[str, Any]] = None, | ||
| 97 | 97 | **kwargs: Any | |
| 98 | 98 | ) -> Dict[str, Any]: | |
| 99 | 99 | """Update an object on the server. | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -13,6 +13,7 @@ disallow_incomplete_defs = true | |||
| 13 | 13 | disallow_subclassing_any = true | |
| 14 | 14 | disallow_untyped_decorators = true | |
| 15 | 15 | disallow_untyped_defs = true | |
| 16 | + no_implicit_optional = true | ||
| 16 | 17 | no_implicit_reexport = true | |
| 17 | 18 | strict_equality = true | |
| 18 | 19 | warn_redundant_casts = true | |
@@ -23,7 +24,6 @@ warn_unused_ignores = true | |||
| 23 | 24 | # The following need to have changes made to be able to enable them: | |
| 24 | 25 | # disallow_any_generics = true | |
| 25 | 26 | # disallow_untyped_calls = true | |
| 26 | - # no_implicit_optional = true | ||
| 27 | 27 | ||
| 28 | 28 | [[tool.mypy.overrides]] # Overrides for currently untyped modules | |
| 29 | 29 | module = [ | |
0 commit comments