Repository navigation
Commit 65abb85
fix(cli): Enable debug before doing auth
Authentication issues are currently hard to debug since `--debug` only
has effect after `gl.auth()` has been called.
For example, a 401 error is printed without any details about the actual
HTTP request being sent:
$ gitlab --debug --server-url https://gitlab.com current-user get
401: 401 Unauthorized
By moving the call to `gl.enable_debug()` the usual debug logs get
printed before the final error message.
Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>1 parent d8a657b commit 65abb85
1 file changed
Lines changed: 2 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -366,14 +366,13 @@ def main() -> None: | |||
| 366 | 366 | ||
| 367 | 367 | try: | |
| 368 | 368 | gl = gitlab.Gitlab.merge_config(vars(options), gitlab_id, config_files) | |
| 369 | + if debug: | ||
| 370 | + gl.enable_debug() | ||
| 369 | 371 | if gl.private_token or gl.oauth_token: | |
| 370 | 372 | gl.auth() | |
| 371 | 373 | except Exception as e: | |
| 372 | 374 | die(str(e)) | |
| 373 | 375 | ||
| 374 | - if debug: | ||
| 375 | - gl.enable_debug() | ||
| 376 | - | ||
| 377 | 376 | gitlab.v4.cli.run( | |
| 378 | 377 | gl, gitlab_resource, resource_action, args_dict, verbose, output, fields | |
| 379 | 378 | ) | |
0 commit comments