fix(types): add explicit submodule import for pyright compatibility · python-gitlab/python-gitlab@84ad3fd · GitHub

1. python-gitlab
2. python-gitlab

Repository navigation

• Code
• Issues16 (16)
• Pull requests15 (15)
• Discussions
• Actions
• Projects
• Security and quality
• Insights

Commit 84ad3fd

Browse filesBrowse the repository at this point in the historyBrowse files

authored and

nejch

committed

fix(types): add explicit submodule import for pyright compatibility

Add `import gitlab.base` inside the TYPE_CHECKING block in repositories.py so that pyright can resolve `gitlab.base.RESTObject`. Without the explicit import, pyright cannot resolve the submodule access via the parent package (implicit submodule access is a runtime loader side effect that type checkers don't model). This caused `_RestObjectBase` to be `Unknown`, propagating through `RepositoryMixin` into `Project` and other classes. Fixes #3342 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

1 parent 4e01d33 commit 84ad3fd
Copy full SHA for 84ad3fd

1 file changed

+2Lines changed: 2 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• gitlab/v4/objects
  • repositories.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎gitlab/v4/objects/repositories.py‎

Copy file name to clipboardExpand all lines: gitlab/v4/objects/repositories.py

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -17,6 +17,8 @@
17	17
18	18	if TYPE_CHECKING:
19	19	# When running mypy we use these as the base classes
	20	+ import gitlab.base
	21	+
20	22	_RestObjectBase = gitlab.base.RESTObject
21	23	else:
22	24	_RestObjectBase = object

0 commit comments

Comments

0 (0)