Repository navigation
Commit 98cd03b
fix(api): do not require Release name for creation
Stop requiring a `name` attribute for creating a Release, since a
release name has not been required since GitLab 12.5.1 parent a9924f4 commit 98cd03b
2 files changed
Lines changed: 19 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -19,7 +19,7 @@ class ProjectReleaseManager(CRUDMixin, RESTManager): | |||
| 19 | 19 | _obj_cls = ProjectRelease | |
| 20 | 20 | _from_parent_attrs = {"project_id": "id"} | |
| 21 | 21 | _create_attrs = RequiredOptional( | |
| 22 | - required=("name", "tag_name", "description"), optional=("ref", "assets") | ||
| 22 | + required=("tag_name", "description"), optional=("name", "ref", "assets") | ||
| 23 | 23 | ) | |
| 24 | 24 | _update_attrs = RequiredOptional( | |
| 25 | 25 | optional=("name", "description", "milestones", "released_at") | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -23,6 +23,24 @@ def test_create_project_release(project, project_file): | |||
| 23 | 23 | assert release.description == release_description | |
| 24 | 24 | ||
| 25 | 25 | ||
| 26 | + def test_create_project_release_no_name(project, project_file): | ||
| 27 | + unnamed_release_tag_name = "v2.3.4" | ||
| 28 | + | ||
| 29 | + project.refresh() # Gets us the current default branch | ||
| 30 | + release = project.releases.create( | ||
| 31 | + { | ||
| 32 | + "tag_name": unnamed_release_tag_name, | ||
| 33 | + "description": release_description, | ||
| 34 | + "ref": project.default_branch, | ||
| 35 | + } | ||
| 36 | + ) | ||
| 37 | + | ||
| 38 | + assert len(project.releases.list()) >= 1 | ||
| 39 | + assert project.releases.get(unnamed_release_tag_name) | ||
| 40 | + assert release.tag_name == unnamed_release_tag_name | ||
| 41 | + assert release.description == release_description | ||
| 42 | + | ||
| 43 | + | ||
| 26 | 44 | def test_update_save_project_release(project, release): | |
| 27 | 45 | updated_description = f"{release.description} updated" | |
| 28 | 46 | release.description = updated_description | |
0 commit comments