Merge pull request #1488 from JohnVillalovos/jlvillal/add_missing_option · python-gitlab/python-gitlab@ac92205 · GitHub

1. python-gitlab
2. python-gitlab

Repository navigation

• Code
• Issues16 (16)
• Pull requests15 (15)
• Discussions
• Actions
• Projects
• Security and quality
• Insights

Commit ac92205

Browse filesBrowse the repository at this point in the historyBrowse files

nejch

authored

Merge pull request #1488 from JohnVillalovos/jlvillal/add_missing_option

chore: add missing optional create parameter for approval_rules

2 parents a11623b + 06a6001 commit ac92205
Copy full SHA for ac92205

1 file changed

+2-1Lines changed: 2 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• gitlab/v4/objects
  • merge_request_approvals.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎gitlab/v4/objects/merge_request_approvals.py‎

Copy file name to clipboardExpand all lines: gitlab/v4/objects/merge_request_approvals.py

+2-1Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -72,7 +72,8 @@ class ProjectApprovalRuleManager(
72	72	_obj_cls = ProjectApprovalRule
73	73	_from_parent_attrs = {"project_id": "id"}
74	74	_create_attrs = RequiredOptional(
75		- required=("name", "approvals_required"), optional=("user_ids", "group_ids")
	75	+ required=("name", "approvals_required"),
	76	+ optional=("user_ids", "group_ids", "protected_branch_ids"),
76	77	)
77	78
78	79

0 commit comments

Comments

0 (0)