Merge pull request #2033 from python-gitlab/jlvillal/module_not_found… · python-gitlab/python-gitlab@b2e6f3b · GitHub

1. python-gitlab
2. python-gitlab

Repository navigation

• Code
• Issues16 (16)
• Pull requests15 (15)
• Discussions
• Actions
• Projects
• Security and quality
• Insights

Commit b2e6f3b

Browse filesBrowse the repository at this point in the historyBrowse files

nejch

authored

Merge pull request #2033 from python-gitlab/jlvillal/module_not_found_error

chore: correct ModuleNotFoundError() arguments

2 parents 38218e5 + 0b7933c commit b2e6f3b
Copy full SHA for b2e6f3b

3 files changed

+4-4Lines changed: 4 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• gitlab
  • cli.py
  • client.py
• tests/unit
  • test_gitlab.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎gitlab/cli.py‎

Copy file name to clipboardExpand all lines: gitlab/cli.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -301,7 +301,7 @@ def main() -> None:
301	301	sys.exit(e)
302	302	# We only support v4 API at this time
303	303	if config.api_version not in ("4",): # dead code # pragma: no cover
304		- raise ModuleNotFoundError(name=f"gitlab.v{config.api_version}.cli")
	304	+ raise ModuleNotFoundError(f"gitlab.v{config.api_version}.cli")
305	305
306	306	# Now we build the entire set of subcommands and do the complete parsing
307	307	parser = _get_parser()

Collapse file

‎gitlab/client.py‎

Copy file name to clipboardExpand all lines: gitlab/client.py

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -116,7 +116,7 @@ def __init__(
116	116
117	117	# We only support v4 API at this time
118	118	if self._api_version not in ("4",):
119		- raise ModuleNotFoundError(name=f"gitlab.v{self._api_version}.objects")
	119	+ raise ModuleNotFoundError(f"gitlab.v{self._api_version}.objects")
120	120	# NOTE: We must delay import of gitlab.v4.objects until now or
121	121	# otherwise it will cause circular import errors
122	122	import gitlab.v4.objects
@@ -209,7 +209,7 @@ def __setstate__(self, state: Dict[str, Any]) -> None:
209	209	# We only support v4 API at this time
210	210	if self._api_version not in ("4",):
211	211	raise ModuleNotFoundError(
212		- name=f"gitlab.v{self._api_version}.objects"
	212	+ f"gitlab.v{self._api_version}.objects"
213	213	) # pragma: no cover, dead code currently
214	214	# NOTE: We must delay import of gitlab.v4.objects until now or
215	215	# otherwise it will cause circular import errors

Collapse file

‎tests/unit/test_gitlab.py‎

Copy file name to clipboardExpand all lines: tests/unit/test_gitlab.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -91,7 +91,7 @@ def test_gitlab_init_with_valid_api_version():
91	91
92	92
93	93	def test_gitlab_init_with_invalid_api_version():
94		- with pytest.raises(ModuleNotFoundError):
	94	+ with pytest.raises(ModuleNotFoundError, match="gitlab.v1.objects"):
95	95	gitlab.Gitlab(api_version="1")
96	96
97	97

0 commit comments

Comments

0 (0)