Repository navigation
Commit c59fbdb
authored
fix(api): replace deprecated attribute in delete_in_bulk() (#1536)
BREAKING CHANGE: The deprecated `name_regex` attribute has been removed
in favor of `name_regex_delete`.
(see https://gitlab.com/gitlab-org/gitlab/-/commit/ce99813cf54)1 parent e3912ca commit c59fbdb
1 file changed
Lines changed: 13 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -31,26 +31,28 @@ class ProjectRegistryTagManager(DeleteMixin, RetrieveMixin, RESTManager): | |||
| 31 | 31 | _path = "/projects/%(project_id)s/registry/repositories/%(repository_id)s/tags" | |
| 32 | 32 | ||
| 33 | 33 | @cli.register_custom_action( | |
| 34 | - "ProjectRegistryTagManager", optional=("name_regex", "keep_n", "older_than") | ||
| 34 | + "ProjectRegistryTagManager", | ||
| 35 | + ("name_regex_delete",), | ||
| 36 | + optional=("keep_n", "name_regex_keep", "older_than"), | ||
| 35 | 37 | ) | |
| 36 | 38 | @exc.on_http_error(exc.GitlabDeleteError) | |
| 37 | - def delete_in_bulk(self, name_regex=".*", **kwargs): | ||
| 39 | + def delete_in_bulk(self, name_regex_delete, **kwargs): | ||
| 38 | 40 | """Delete Tag in bulk | |
| 39 | 41 | ||
| 40 | 42 | Args: | |
| 41 | - name_regex (string): The regex of the name to delete. To delete all | ||
| 42 | - tags specify .*. | ||
| 43 | - keep_n (integer): The amount of latest tags of given name to keep. | ||
| 44 | - name_regex_keep (string): The regex of the name to keep. This value | ||
| 45 | - overrides any matches from name_regex. | ||
| 46 | - older_than (string): Tags to delete that are older than the given time, | ||
| 47 | - written in human readable form 1h, 1d, 1month. | ||
| 48 | - **kwargs: Extra options to send to the server (e.g. sudo) | ||
| 43 | + name_regex_delete (string): The regex of the name to delete. To delete all | ||
| 44 | + tags specify .*. | ||
| 45 | + keep_n (integer): The amount of latest tags of given name to keep. | ||
| 46 | + name_regex_keep (string): The regex of the name to keep. This value | ||
| 47 | + overrides any matches from name_regex. | ||
| 48 | + older_than (string): Tags to delete that are older than the given time, | ||
| 49 | + written in human readable form 1h, 1d, 1month. | ||
| 50 | + **kwargs: Extra options to send to the server (e.g. sudo) | ||
| 49 | 51 | Raises: | |
| 50 | 52 | GitlabAuthenticationError: If authentication is not correct | |
| 51 | 53 | GitlabDeleteError: If the server cannot perform the request | |
| 52 | 54 | """ | |
| 53 | 55 | valid_attrs = ["keep_n", "name_regex_keep", "older_than"] | |
| 54 | - data = {"name_regex": name_regex} | ||
| 56 | + data = {"name_regex_delete": name_regex_delete} | ||
| 55 | 57 | data.update({k: v for k, v in kwargs.items() if k in valid_attrs}) | |
| 56 | 58 | self.gitlab.http_delete(self.path, query_data=data, **kwargs) | |
0 commit comments