Repository navigation
Commit e825653
committed
chore: correct type-hints for per_page attrbute
There are occasions where a GitLab `list()` call does not return the
`x-per-page` header. For example the listing of custom attributes.
Update the type-hints to reflect that.1 parent 9897c98 commit e825653
2 files changed
Lines changed: 3 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -302,7 +302,7 @@ def next_page(self) -> Optional[int]: | |||
| 302 | 302 | return self._list.next_page | |
| 303 | 303 | ||
| 304 | 304 | @property | |
| 305 | - def per_page(self) -> int: | ||
| 305 | + def per_page(self) -> Optional[int]: | ||
| 306 | 306 | """The number of items per page.""" | |
| 307 | 307 | return self._list.per_page | |
| 308 | 308 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1039,11 +1039,9 @@ def next_page(self) -> Optional[int]: | |||
| 1039 | 1039 | return int(self._next_page) if self._next_page else None | |
| 1040 | 1040 | ||
| 1041 | 1041 | @property | |
| 1042 | - def per_page(self) -> int: | ||
| 1042 | + def per_page(self) -> Optional[int]: | ||
| 1043 | 1043 | """The number of items per page.""" | |
| 1044 | - if TYPE_CHECKING: | ||
| 1045 | - assert self._per_page is not None | ||
| 1046 | - return int(self._per_page) | ||
| 1044 | + return int(self._per_page) if self._per_page is not None else None | ||
| 1047 | 1045 | ||
| 1048 | 1046 | # NOTE(jlvillal): When a query returns more than 10,000 items, GitLab doesn't return | |
| 1049 | 1047 | # the headers 'x-total-pages' and 'x-total'. In those cases we return None. | |
0 commit comments