test(packages): update tests for downloading with response iterator · python-gitlab/python-gitlab@ec61e73 · GitHub

1. python-gitlab
2. python-gitlab

Repository navigation

• Code
• Issues16 (16)
• Pull requests15 (15)
• Discussions
• Actions
• Projects
• Security and quality
• Insights

Commit ec61e73

Browse filesBrowse the repository at this point in the historyBrowse files

TCatshoek

committed

test(packages): update tests for downloading with response iterator

Adapted the existing tests for the new iterator=True argument

1 parent 8580a77 commit ec61e73
Copy full SHA for ec61e73

2 files changed

+5-5Lines changed: 5 additions & 5 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• tests
  • functional/api
    • test_packages.py
  • unit
    • test_utils.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎tests/functional/api/test_packages.py‎

Copy file name to clipboardExpand all lines: tests/functional/api/test_packages.py

+2-4Lines changed: 2 additions & 4 deletions

Original file line number	Diff line number	Diff line change
@@ -53,8 +53,7 @@ def test_stream_generic_package(project):
53	53	package_name=package_name,
54	54	package_version=package_version,
55	55	file_name=file_name,
56		- streamed=True,
57		- action="iterator",
	56	+ iterator=True,
58	57	)
59	58
60	59	assert isinstance(bytes_iterator, Iterator)
@@ -90,8 +89,7 @@ def test_stream_generic_package_to_file(tmp_path, project):
90	89	package_name=package_name,
91	90	package_version=package_version,
92	91	file_name=file_name,
93		- streamed=True,
94		- action="iterator",
	92	+ iterator=True,
95	93	)
96	94
97	95	with open(path, "wb") as f:

Collapse file

‎tests/unit/test_utils.py‎

Copy file name to clipboardExpand all lines: tests/unit/test_utils.py

+3-1Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -36,7 +36,9 @@ def test_response_content(capsys):
36	36	)
37	37
38	38	resp = requests.get("https://example.com", stream=True)
39		- utils.response_content(resp, streamed=True, action=None, chunk_size=1024)
	39	+ utils.response_content(
	40	+ resp, streamed=True, iterator=False, action=None, chunk_size=1024
	41	+ )
40	42
41	43	captured = capsys.readouterr()
42	44	assert "test" in captured.out

0 commit comments

Comments

0 (0)