Repository navigation
Commit f734c58
chore: update to mypy 1.16.0 and resolve issues found
There was an error in the type-hints that was detected when updating
to mypy 1.16.0
The error was:
$ mypy
gitlab/v4/cli.py:411: error: Argument 1 to "cls_to_gitlab_resource" has incompatible type "type[Any]"; expected "RESTObject" [arg-type]
Found 1 error in 1 file (checked 246 source files)1 parent 378a836 commit f734c58
4 files changed
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -107,7 +107,7 @@ def gitlab_resource_to_cls( | |||
| 107 | 107 | return class_type | |
| 108 | 108 | ||
| 109 | 109 | ||
| 110 | - def cls_to_gitlab_resource(cls: RESTObject) -> str: | ||
| 110 | + def cls_to_gitlab_resource(cls: type[RESTObject]) -> str: | ||
| 111 | 111 | dasherized_uppercase = camel_upperlower_regex.sub(r"\1-\2", cls.__name__) | |
| 112 | 112 | dasherized_lowercase = camel_lowerupper_regex.sub(r"\1-\2", dasherized_uppercase) | |
| 113 | 113 | return dasherized_lowercase.lower() | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -394,7 +394,7 @@ def extend_parser(parser: argparse.ArgumentParser) -> argparse.ArgumentParser: | |||
| 394 | 394 | subparsers.required = True | |
| 395 | 395 | ||
| 396 | 396 | # populate argparse for all Gitlab Object | |
| 397 | - classes = set() | ||
| 397 | + classes: set[type[gitlab.base.RESTObject]] = set() | ||
| 398 | 398 | for cls in gitlab.v4.objects.__dict__.values(): | |
| 399 | 399 | if not isinstance(cls, type): | |
| 400 | 400 | continue | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -4,7 +4,7 @@ black==25.1.0 | |||
| 4 | 4 | commitizen==4.8.2 | |
| 5 | 5 | flake8==7.2.0 | |
| 6 | 6 | isort==6.0.1 | |
| 7 | - mypy==1.15.0 | ||
| 7 | + mypy==1.16.0 | ||
| 8 | 8 | pylint==3.3.7 | |
| 9 | 9 | pytest==8.3.5 | |
| 10 | 10 | responses==0.25.7 | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -161,7 +161,7 @@ def error(self, message): | |||
| 161 | 161 | "Raise error instead of exiting on invalid arguments, to make testing easier" | |
| 162 | 162 | raise ValueError(message) | |
| 163 | 163 | ||
| 164 | - class Fake: | ||
| 164 | + class Fake(gitlab.base.RESTObject): | ||
| 165 | 165 | _id_attr = None | |
| 166 | 166 | ||
| 167 | 167 | class FakeManager(CreateMixin, UpdateMixin, gitlab.base.RESTManager): | |
0 commit comments