FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Create MR with reviewers · Issue #1267 · python-gitlab/python-gitlab · GitHub

Repository navigation

Create MR with reviewers #1267

Description

I didn't find an option to assign reviewers while creating MR.
As I see, gitlab REST API also doesn't have this option yet (should I also file an issue about it here?)

Activity

  1. JoelFeiner commented on Jan 26, 2021

    @mary3000 I see reviewer_ids in the API. Perhaps the documentation just hadn't been updated yet?

  2. m00lecule commented on Feb 9, 2021

    Hello! I am also struggling to apply following in python-gitlab 2.6.0

        mr = project.mergerequests.list(state="opened", wip="no", ordered_by="updated_at", sort="asc", per_page=999)[0]
        review_group = gl.groups.get(gitlab_review_group_name)
        members = review_group.members.list()
        mr.reviewer_ids = [members[0].get_id()]
        mr.save()

    Result:

    Traceback (most recent call last):
        mr.save()
      File "/XXXXXXXXXX/.venv/lib/python3.6/site-packages/gitlab/mixins.py", line 385, in save
        server_data = self.manager.update(obj_id, updated_data, **kwargs)
      File "XXXXXXXXXXXXX/.venv/lib/python3.6/site-packages/gitlab/exceptions.py", line 281, in wrapped_f
        raise error(e.error_message, e.response_code, e.response_body) from e
    gitlab.exceptions.GitlabUpdateError: 400: assignee_id, assignee_ids, description, labels, add_labels, remove_labels, milestone_id, remove_source_branch, allow_collaboration, allow_maintainer_to_push, squash, target_branch, title, state_event, discussion_locked are missing, at least one parameter must be provided

    Edit:

    This feature has not been added yet - link

  3. mattiasb commented on Feb 27, 2021

    This should be in now since a couple of days. See here

  4. spyoungtech commented on Apr 13, 2021

    Contributor

    It would also be nice to be able to change the reviewers on an existing merge request.

  5. spyoungtech commented on Apr 13, 2021

    Contributor

    As a workaround for this, you can do the following:

    # update the reviewers on the MR
    updated_data = mr.manager.update(mr.get_id(), {'reviewer_ids': [1,2,3]})
    
    #  for completeness, update the object from the server response
    if updated_data:
        mr._update_attrs(updated_data)
  6. mykolasolodukha commented on Aug 8, 2022

    This might've been closed now since the #1396 is merged.

  7. nejch commented on Aug 9, 2022

    Member

    You're right @mykolasolodukha, this does already work. Thanks for the catch!

    mr = project.mergerequests.create(
        {
            "source_branch": "your-branch",
            "target_branch": "main",
            "title": "your MR",
            "reviewer_ids": [reviewer_id]
        }
    )
    
    mr.reviewer_ids = [reviewer_id, another_reviewer_id]
    mr.save()
  8. locked as resolved and limited conversation to collaborators on Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions


      Back | FazBrowse Home | New Git URL