Get rid of all custom URL encoding · Issue #1356 · python-gitlab/python-gitlab · GitHub

On the other hand, need to check #1006 and the current state of

Lines 513 to 524 in 96d2805

    
           # Requests assumes that `.` should not be encoded as %2E and will make 
        
           # changes to urls using this encoding. Using a prepped request we can 
        
           # get the desired behavior. 
        
           # The Requests behavior is right but it seems that web servers don't 
        
           # always agree with this decision (this is the case with a default 
        
           # gitlab installation) 
        
           req = requests.Request(verb, url, json=json, data=data, params=params, **opts) 
        
           prepped = self.session.prepare_request(req) 
        
           prepped.url = utils.sanitized_url(prepped.url) 
        
           settings = self.session.merge_environment_settings( 
        
               prepped.url, {}, streamed, verify, None 
        
           )

If proxies handle it differently maybe an additional arg for e.g. encode_xyz=True might help.

gitlab/utils.py:    return id.replace("/", "%2F").replace("#", "%23")
gitlab/utils.py:        return value.replace("/", "%2F")
gitlab/utils.py:    new_path = parsed.path.replace(".", "%2E")
gitlab/v4/objects/branches.py:        id = self.get_id().replace("/", "%2F")
gitlab/v4/objects/branches.py:        id = self.get_id().replace("/", "%2F")
gitlab/v4/objects/features.py:        path = "%s/%s" % (self.path, name.replace("/", "%2F"))
gitlab/v4/objects/files.py:        self.file_path = self.file_path.replace("/", "%2F")
gitlab/v4/objects/files.py:        file_path = self.get_id().replace("/", "%2F")
gitlab/v4/objects/files.py:        file_path = file_path.replace("/", "%2F")
gitlab/v4/objects/files.py:        file_path = new_data.pop("file_path").replace("/", "%2F")
gitlab/v4/objects/files.py:        file_path = file_path.replace("/", "%2F")
gitlab/v4/objects/files.py:        path = "%s/%s" % (self.path, file_path.replace("/", "%2F"))
gitlab/v4/objects/files.py:        file_path = file_path.replace("/", "%2F").replace(".", "%2E")
gitlab/v4/objects/files.py:        file_path = file_path.replace("/", "%2F").replace(".", "%2E")
gitlab/v4/objects/repositories.py:        submodule = submodule.replace("/", "%2F")  # .replace('.', '%2E')
gitlab/v4/objects/tags.py:        id = self.get_id().replace("/", "%2F")

Hi, I made a pullrequest to fix the lazy object deletion (fix #1494): #1541
Let me know if you need any action from me.

chore: stop encoding '.' to '%2E'

fix: stop encoding '.' to '%2E'

chore: remove custom URL encoding

fix: remove custom URL encoding

Get rid of all custom URL encoding · Issue #1356 · python-gitlab/python-gitlab · GitHub

Repository navigation

Get rid of all custom URL encoding #1356

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	# Requests assumes that `.` should not be encoded as %2E and will make
	# changes to urls using this encoding. Using a prepped request we can
	# get the desired behavior.
	# The Requests behavior is right but it seems that web servers don't
	# always agree with this decision (this is the case with a default
	# gitlab installation)
	req = requests.Request(verb, url, json=json, data=data, params=params, **opts)
	prepped = self.session.prepare_request(req)
	prepped.url = utils.sanitized_url(prepped.url)
	settings = self.session.merge_environment_settings(
	prepped.url, {}, streamed, verify, None
	)

Get rid of all custom URL encoding · Issue #1356 · python-gitlab/python-gitlab · GitHub

Repository navigation

Get rid of all custom URL encoding #1356

Description

Activity

oux commented on Jul 8, 2021

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions