FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: functional project service test by JohnVillalovos · Pull Request #1500 · python-gitlab/python-gitlab · GitHub

  1. python-gitlab
  2. python-gitlab

Repository navigation

fix: functional project service test - #1500

Merged
nejch merged 3 commits into
python-gitlab:masterfrom
JohnVillalovos:jlvillal/func_project
Jun 9, 2021
ConversationCommits (3)ChecksFiles changed
Merged

fix: functional project service test#1500
nejch merged 3 commits into
python-gitlab:masterfrom
JohnVillalovos:jlvillal/func_project

Conversation

JohnVillalovos commented Jun 4, 2021 •
edited
Loading

Copy link
Copy Markdown
Member 
The PR: https://github.com/python-gitlab/python-gitlab/pull/1462 was
not able to merge due to a change in the latest version of Gitlab.

More details here:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/61646

Update the functional test to first create the project service before
doing a get.

Also bring in the two commits from #1462

fix: functional project service test
e691762 
The PR: #1462 was
not able to merge due to a change in the latest version of Gitlab.

More details here:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/61646

Update the functional test to first create the project service before
doing a get.
JohnVillalovos requested a review from nejch June 4, 2021 00:40

JohnVillalovos commented Jun 4, 2021

Copy link
Copy Markdown
Member Author

@benjamb Since you pointed out the issue, I wanted to bring this to your attention.

codecov-commenter commented Jun 4, 2021 •
edited by codecov Bot
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.04%. Comparing base (d3fac50) to head (e6182ab).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1500   +/-   ##
=======================================
  Coverage   91.04%   91.04%           
=======================================
  Files          74       74           
  Lines        4145     4145           
=======================================
  Hits         3774     3774           
  Misses        371      371
Flag Coverage Δ
cli_func_v4 80.69% <ø> (ø)
py_func_v4 79.97% <ø> (ø)
unit 82.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

benjamb commented Jun 4, 2021

Copy link
Copy Markdown
Contributor

@JohnVillalovos Nice one, thanks!

JohnVillalovos requested a review from max-wittig June 4, 2021 13:41
nejch merged commit 093db9d into python-gitlab:master Jun 9, 2021
JohnVillalovos deleted the jlvillal/func_project branch January 4, 2022 06:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nejch Awaiting requested review from nejch
max-wittig Awaiting requested review from max-wittig

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL