FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(COPYING): Use the combined LGPGL and GPL license text. by JohnVillalovos · Pull Request #3420 · python-gitlab/python-gitlab · GitHub

  1. python-gitlab
  2. python-gitlab

Repository navigation

fix(COPYING): Use the combined LGPGL and GPL license text. - #3420

Merged
JohnVillalovos merged 1 commit into
mainfrom
jlvillal/license
Jul 29, 2026
ConversationCommits (1)ChecksFiles changed
Merged

fix(COPYING): Use the combined LGPGL and GPL license text.#3420
JohnVillalovos merged 1 commit into
mainfrom
jlvillal/license

Conversation

JohnVillalovos commented Jul 14, 2026

Copy link
Copy Markdown
Member

Taken from https://www.gnu.org/licenses/lgpl-3.0.html in particular from https://www.gnu.org/licenses/lgpl+gpl-3.0.txt

There is a bug in the https://github.com/gl-gitaly/go-license-detector where it only detects LGPL if the license contains both LGPL and GPL text in it.

This bug causes the project to not be recognized as LGPL at GitLab.

Discussed in: https://gitlab.com/gitlab-org/gitlab/-/work_items/543742

Related: #3395

Copilot AI review requested due to automatic review settings July 14, 2026 16:20
Copilot AI reviewed Jul 14, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull request overview

Updates the repository’s COPYING license text to use the official combined LGPLv3 + GPLv3 wording, matching the GNU-provided lgpl+gpl-3.0.txt, to improve compatibility with GitLab’s (and go-license-detector’s) license detection and ensure the project is recognized as LGPL.

Changes:

  • Replace the LGPLv3 COPYING text with the combined LGPLv3 + GPLv3 license text (as published by GNU).
  • Update the FSF URL in the copyright header from http:// to https://.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

JohnVillalovos mentioned this pull request Jul 14, 2026
Closed
JohnVillalovos requested a review from nejch July 14, 2026 16:22

codecov Bot commented Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.78%. Comparing base (aff7954) to head (a7678c8).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3420   +/-   ##
=======================================
  Coverage   95.78%   95.78%           
=======================================
  Files         100      100           
  Lines        6172     6172           
=======================================
  Hits         5912     5912           
  Misses        260      260
Flag Coverage Δ
api_func_v4 83.95% <ø> (+0.16%) ⬆️
cli_func_v4 78.79% <ø> (ø)
unit 90.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

JohnVillalovos force-pushed the jlvillal/license branch 2 times, most recently from c2f7970 to b3f0404 Compare July 28, 2026 05:21
fix(COPYING): Use the combined LGPGL and GPL license text.
a7678c8 
Taken from https://www.gnu.org/licenses/lgpl-3.0.html in particular from
https://www.gnu.org/licenses/lgpl+gpl-3.0.txt

There is a bug in the https://github.com/gl-gitaly/go-license-detector
where it only detects LGPL if the license contains both LGPL and GPL
text in it.

This bug causes the project to not be recognized as LGPL at GitLab.

Discussed in: https://gitlab.com/gitlab-org/gitlab/-/work_items/543742

Related: #3395

JohnVillalovos commented Jul 29, 2026

Copy link
Copy Markdown
Member Author

I'm going to go ahead and merge this.

JohnVillalovos merged commit b6e65dd into main Jul 29, 2026
18 checks passed
JohnVillalovos deleted the jlvillal/license branch July 29, 2026 15:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
nejch Awaiting requested review from nejch
max-wittig Awaiting requested review from max-wittig

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL