Repository navigation
fix(docker): run container as non-root user - #3429
Closed
chernojagne wants to merge 1 commit into
Closed
chernojagne wants to merge 1 commit into
chernojagne wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #3429 +/- ##
==========================================
+ Coverage 92.23% 95.78% +3.54%
==========================================
Files 100 100
Lines 6172 6172
==========================================
+ Hits 5693 5912 +219
+ Misses 479 260 -219
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
Closing this — we're revising how we approach these contributions and would rather withdraw it than leave it open unattended. Apologies for the noise, and thanks. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add a non-root user (app, UID 1001) to the Dockerfile and set USER 1001
before the container entrypoint. Running as root in a container is a security
risk — it widens the blast radius if the process is compromised, and many
Kubernetes deployments enforce a non-zero runAsUser policy that would
reject a root container at admission.
The RUN instruction uses both Alpine-style (addgroup -S / adduser -S)
and glibc-style (groupadd --system / useradd --system) forms so the
image continues to build from either python:3.x-alpine or
python:3.x-slim base images.
Documentation and testing