Repository navigation
fix: add retry_transient_errors to merge_config - #3437
nickbroon wants to merge 1 commit into
Conversation
Sorry, something went wrong.
|
It would be nice to have this merged before the next release. 🙂 |
Sorry, something went wrong.
`merge_config()` supports other options that the constructor and `from_config()` factory method do, and was just missing this one.
|
@nickbroon Could we have some tests for this as well? |
Sorry, something went wrong.
Are there any existing tests of Gitlab.merge_config() that I can extend? |
Sorry, something went wrong.
Replying to myself; There are no immediately obviously existing tests, or even uses, of merge_config() other than a single call from the CLI code: https://github.com/search?q=repo%3Apython-gitlab%2Fpython-gitlab+merge_config&type=code |
Sorry, something went wrong.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Explicit False values currently cannot override a configuration value of True.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Adds retry_transient_errors handling to Gitlab.merge_config().
Changes:
- Merges the retry setting from explicit options or configuration.
| File | Description |
|---|---|
| gitlab/client.py | Passes the merged retry setting to the client constructor. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
| retry_transient_errors=options.get("retry_transient_errors") | ||
| or config.retry_transient_errors, |
There was a problem hiding this comment.
Does the existing ssl_verify config option must also have this same behaviour?
Sorry, something went wrong.
merge_config() supports other options that the constructor and from_config() factory method do, and was just missing this one.