The exact API naming is open for discussion, but keeping cruise would match the underlying Tapo protocol and existing implementations.
It could also expose action features such as:
ptz_cruise_horizontal
ptz_cruise_vertical
ptz_cruise_stop
Device available for testing
I can test this on a physical C200:
Hardware: 1.0
Firmware: 1.3.17 Build 260112 Rel.54862n(4555)
ptz component version: 1
The device is already covered by the fixture added in #1760.
Open question
The C200 advertises PTZ/motor capabilities but does not appear to explicitly advertise cruise support.
It would be useful to determine whether cruise:
is available on all compatible PTZ devices,
can be detected through another capability/query,
or should initially be exposed for PTZ devices and let unsupported devices return the protocol error.
I would prefer avoiding a model-specific whitelist.
Cruise is also a persistent motor mode, so manual pan / tilt / move commands may fail while it is active. I would avoid stopping cruise implicitly unless that behavior is intentional.
Tests
If accepted, I can provide:
unit tests for horizontal / vertical / stop payloads,
physical tests on the C200,
a test for interaction with manual PTZ movement while cruise is active.
Activity