devtools/dump_devinfo.py should be modified to perform component_nego on child devices, and perform query() on known and implemented modules in addition to current smartrequests approach.
I started to look into the module queries in deump_devinfo as part of this issue and ran into a few issues. I have opened #889 to track it so we can try to close out this particular issue for 0.7.0.
w.r.t the extra child update queries I think at the moment dump_devinfo will capture any child queries even if we're not actually making them in the modules, i.e. get_on_off_gradually_info which is not used as the data is also available on the child_device_info for the ks240. See #890 for an updated ks240 fixture from a fresh dump_devinfo. This child info will also be included in the child fixture if a separate child fixture is saved, i.e. for a hub device.
Is there something else you were thinking of here or are we good to close?
I think we are good to close this, as like you said, it would be necessary to keep a list of commands that are not currently used & we like to have as much information as possible in the fixtures even when we are not currently using them. Thanks for digging into this 👍
Activity
rytilahti commented on Apr 25, 2024
Partially done in #858, the question whether we want to have extra child update queries also is unclear.
sdb9696 commented on May 1, 2024
I started to look into the module queries in deump_devinfo as part of this issue and ran into a few issues. I have opened #889 to track it so we can try to close out this particular issue for 0.7.0.
w.r.t the extra child update queries I think at the moment dump_devinfo will capture any child queries even if we're not actually making them in the modules, i.e. get_on_off_gradually_info which is not used as the data is also available on the child_device_info for the ks240. See #890 for an updated ks240 fixture from a fresh dump_devinfo. This child info will also be included in the child fixture if a separate child fixture is saved, i.e. for a hub device.
Is there something else you were thinking of here or are we good to close?
rytilahti commented on May 5, 2024
I think we are good to close this, as like you said, it would be necessary to keep a list of commands that are not currently used & we like to have as much information as possible in the fixtures even when we are not currently using them. Thanks for digging into this 👍