rope_autoimport: continue on name-defined diagnostics provided by mypy · python-lsp/python-lsp-server@f2dea82 · GitHub

python-lsp / python-lsp-server Public

• Notifications You must be signed in to change notification settings
• Fork 248
• Star 2.6k

• Code
• Issues 150
• Pull requests 22
• Discussions
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit f2dea82

Browse filesBrowse the repository at this point in the historyBrowse files

LarsMichelsen

committed

rope_autoimport: continue on name-defined diagnostics provided by mypy

Previously the autoimport code action did only act on diagnostics which message contained "undefined name". In my case this did not trigger at all so that the plugin failed to provide code actions. This change now additionally looks at name-defined error codes provided by mypy.

1 parent 89265cd commit f2dea82
Copy full SHA for f2dea82

1 file changed

+5-1Lines changed: 5 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• pylsp/plugins
  • rope_autoimport.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎pylsp/plugins/rope_autoimport.py‎

Copy file name to clipboardExpand all lines: pylsp/plugins/rope_autoimport.py

+5-1Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -337,7 +337,11 @@ def pylsp_code_actions(
337	337	log.debug(f"textDocument/codeAction: {document} {range} {context}")
338	338	code_actions = []
339	339	for diagnostic in context.get("diagnostics", []):
340		- if "undefined name" not in diagnostic.get("message", "").lower():
	340	+ matched_message = "undefined name" not in diagnostic.get("message", "").lower()
	341	+ # Provided by mypy
	342	+ matched_code = diagnostic.get("code", "") == "name-defined"
	343	+
	344	+ if not matched_message and not matched_code:
341	345	continue
342	346
343	347	word = get_name_or_module(document, diagnostic)

0 commit comments

Comments

0 (0)