FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

refactored Client.send_pdu() · python-smpplib/python-smpplib@df39439 · GitHub

Commit df39439

Browse files
authored andcommitted
refactored Client.send_pdu()
use socket.sendall instead of socket.send in a loop
1 parent b9ec1fc commit df39439

1 file changed

Lines changed: 5 additions & 13 deletions

File tree

‎smpplib/client.py‎

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -207,22 +207,14 @@ def send_pdu(self, p):
207207
))
208208

209209
self.logger.debug('Sending %s PDU', p.command)
210-
211210
generated = p.generate()
212-
213211
self.logger.debug('>>%s (%d bytes)', binascii.b2a_hex(generated), len(generated))
214212

215-
sent = 0
216-
217-
while sent < len(generated):
218-
try:
219-
sent_last = self._socket.send(generated[sent:])
220-
except socket.error as e:
221-
self.logger.warning(e)
222-
raise exceptions.ConnectionError()
223-
if sent_last == 0:
224-
raise exceptions.ConnectionError()
225-
sent += sent_last
213+
try:
214+
self._socket.sendall(generated)
215+
except socket.error as e:
216+
self.logger.warning(e)
217+
raise exceptions.ConnectionError()
226218

227219
return True
228220

0 commit comments

Comments
 (0)

Back | FazBrowse Home | New Git URL