[feature] add non-exhausive URI validation #388

{{editor}}'s edit

{{actor}} deleted this content .

{{editor}}'s edit

nandgator
Apr 2, 2024
Collaborator

Succeeds:

Suggestions are welcome:

Lines 24 to 41 in cdc987d

    
           @validator 
        
           def uri(value: str, /): 
        
               """Return whether or not given value is a valid URI. 
        
               Examples: 
        
                   >>> uri('mailto:example@domain.com') 
        
                   # Output: True 
        
                   >>> uri('file:path.txt') 
        
                   # Output: ValidationError(func=uri, ...) 
        
               Args: 
        
                   value: 
        
                       URI to validate. 
        
               Returns: 
        
                   (Literal[True]): If `value` is a valid URI. 
        
                   (ValidationError): If `value` is an invalid URI. 
        
               """

You must be logged in to vote

All reactions

tofetpuzo
Jun 23, 2024

are you taking any new suggestions?

You must be logged in to vote

All reactions

0 replies

nandgator
Jun 24, 2024
Collaborator Author

Constructive ones, please go ahead.

You must be logged in to vote

All reactions

0 replies

{{editor}}'s edit

{{actor}} deleted this content .

{{editor}}'s edit

tofetpuzo
Jun 24, 2024

--- # Define a list of valid URI schemes => VALID_SCHEMES = ['http', 'https', 'ftp', 'mailto', 'file']

We could make the parameter-> value(str) flexible perhaps not restrict it to a type str, could be src/path/to/file; which could contain different urls
do a recursive search(regex expression perhaps) to match pattern

You must be logged in to vote

All reactions

0 replies

tofetpuzo
Jun 26, 2024

is it something we should do?

You must be logged in to vote

All reactions

0 replies

nandgator
Jun 27, 2024
Collaborator Author

Something similar yeah.

You must be logged in to vote

All reactions

0 replies

tofetpuzo
Jul 3, 2024

can I take up the challenge :)?

You must be logged in to vote

All reactions

0 replies

nandgator
Jul 4, 2024
Collaborator Author

Sure, go ahead.

You must be logged in to vote

All reactions

0 replies

{{editor}}'s edit

{{actor}} deleted this content .

{{editor}}'s edit

tofetpuzo
Jul 9, 2024

Hey @yozachar ,can we use socket.inet_aton(ip) in python to validate ip addresses as a function then update the schema in uri.py?

   # URL-based schemes
    if any(
        value.startswith(item + "://") for item in {
            "ftp", "ftps", "git", "http", "https",
            "irc", "rtmp", "rtmps", "rtsp", "sftp",
            "ssh", "telnet", "gopher", "ldap", "sip",
            "nfs", "mqtt", "smb", "udp"
        }
    ):

You must be logged in to vote

All reactions

0 replies

{{editor}}'s edit

{{actor}} deleted this content .

{{editor}}'s edit

nandgator
Jul 10, 2024
Collaborator Author

IP addresses are already validated in ip_address.py. Why use socket.inet_aton?

You must be logged in to vote

All reactions

0 replies

{{editor}}'s edit

{{actor}} deleted this content .

{{editor}}'s edit

tofetpuzo
Jul 10, 2024

Hi, that is cool I looked at the message thread, something about this error below , was why I thought this feature was asked for I guess, see code below.

import validators

streamurl = "rtmp://192.168.1.123:1935/live/test"
print(validators.url(streamurl))

Output:
ValidationError(func=url, args={'value': 'rtmp://192.168.1.123:1935/live/test'})

Or does it mean we just want to validate other schemas? like the ones few ones below, that I could not find in uri.py

proposed schemas

"Uri":  {
"udp": udp://192.168.1.1:1234/path;param=value?,

"gopher": gopher://gopher.example.com/1/path;type=1?search#frag,\
"ldap": ldap://ldap.example.com/cn=John%20Doe,dc=example,dc=com;scope=one?sn#frag, \
"sip":sip://user:password@sip.example.com/path;transport=tcp?subject=Hello#frag, \
"smb": smb://fileserver.example.com/share/path;param=value?query=1#fragment\
 }

Few Thoughts

Have a regex expression : that complies the schema above.
uri_regrex: re.compile()
e.g

  # Validate using regex for URL-based schemes
    if uri_regex.match(value):
        return True

You must be logged in to vote

All reactions

11 replies

e3krisztian Oct 29, 2024

No worries, I had another idea, and implemented it in

feat: allow custom URL scheme validation #409

It can be optionally further enhanced with providing alternative validate_scheme implementations, like publicly exposing the default one, and maybe some of these:

def accept_all_schemes(scheme):
    return True

def accept_iana_schemes(scheme):
    # https://www.iana.org/assignments/uri-schemes/uri-schemes.xhtml
    # I do not intend to, but someone might want to implement this as well
    ...

def accept_schemes(*accepted_schemes):
    def validate(scheme):
        return scheme in accepted_schemes
    return validate

which could be used like

validators.url(value, validate_scheme=accept_all_schemes)
validators.url(value, validate_scheme=accept_schemes("http", "https"))

All reactions

tofetpuzo Dec 4, 2024

Apologies, I have been "mia". Has this feature been implemented?

All reactions

nandgator Dec 5, 2024
Collaborator Author

Apologies, I have been "mia". Has this feature been implemented?

Nope.

#409 (comment)

All reactions

{{editor}}'s edit

{{actor}} deleted this content .

{{editor}}'s edit

tofetpuzo Dec 6, 2024

I will work on it I have been super busy, I have started already.

All reactions

{{editor}}'s edit

{{actor}} deleted this content .

{{editor}}'s edit

tofetpuzo Mar 7, 2026

@nandgator
hny! I worked on telnet, just got time to impl. it.
cc PR cheers!

All reactions

[feature] add non-exhausive URI validation · python-validators/validators · Discussion #388 · GitHub

Repository navigation

[feature] add non-exhausive URI validation #388

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

nandgator Apr 2, 2024 Collaborator

Replies: 10 comments · 11 replies

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

nandgator Jun 24, 2024 Collaborator Author

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

nandgator Jun 27, 2024 Collaborator Author

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

nandgator Jul 4, 2024 Collaborator Author

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

nandgator Jul 10, 2024 Collaborator Author

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

nandgator Dec 5, 2024 Collaborator Author

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Uh oh!

nandgator
Apr 2, 2024
Collaborator

Replies: 10 comments 11 replies

nandgator
Jun 24, 2024
Collaborator Author

nandgator
Jun 27, 2024
Collaborator Author

nandgator
Jul 4, 2024
Collaborator Author

nandgator
Jul 10, 2024
Collaborator Author

nandgator Dec 5, 2024
Collaborator Author