ci(workflows,cli): fix e2e workflow script chaining and GitHub API auth · pythonnative/pythonnative@01d1968 · GitHub

pythonnative / pythonnative Public

• Notifications You must be signed in to change notification settings
• Fork 23
• Star 131

• Code
• Issues 11
• Pull requests 4
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 01d1968

Browse filesBrowse the repository at this point in the historyBrowse files

owenthcarey

committed

ci(workflows,cli): fix e2e workflow script chaining and GitHub API auth

1 parent 298f884 commit 01d1968
Copy full SHA for 01d1968

2 files changed

+12-7Lines changed: 12 additions & 7 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• .github/workflows
  • e2e.yml
• src/pythonnative/cli
  • pn.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎.github/workflows/e2e.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/e2e.yml

+7-6Lines changed: 7 additions & 6 deletions

Original file line number	Diff line number	Diff line change
@@ -40,12 +40,11 @@ jobs:
40	40	with:
41	41	api-level: 31
42	42	arch: x86_64
43		- script: |
44		- export PATH="$HOME/.maestro/bin:$PATH"
45		- cd examples/hello-world
46		- pn run android
47		- sleep 5
48		- cd ../..
	43	+ script: >-
	44	+ cd examples/hello-world &&
	45	+ pn run android &&
	46	+ sleep 5 &&
	47	+ cd ../.. &&
49	48	maestro test tests/e2e/android.yaml
50	49
51	50	e2e-ios:
@@ -73,6 +72,8 @@ jobs:
73	72	- name: Build and launch iOS app
74	73	working-directory: examples/hello-world
75	74	run: pn run ios
	75	+ env:
	76	+ GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
76	77
77	78	- name: Run E2E tests
78	79	run: maestro --platform ios test tests/e2e/ios.yaml

Collapse file

‎src/pythonnative/cli/pn.py‎

Copy file name to clipboardExpand all lines: src/pythonnative/cli/pn.py

+5-1Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -156,7 +156,11 @@ def _copy_bundled_template_dir(template_dir: str, destination: str) -> None:
156	156
157	157
158	158	def _github_json(url: str) -> Any:
159		- req = urllib.request.Request(url, headers={"User-Agent": "pythonnative-cli"})
	159	+ headers: dict[str, str] = {"User-Agent": "pythonnative-cli"}
	160	+ token = os.environ.get("GITHUB_TOKEN") or os.environ.get("GH_TOKEN")
	161	+ if token:
	162	+ headers["Authorization"] = f"Bearer {token}"
	163	+ req = urllib.request.Request(url, headers=headers)
160	164	with urllib.request.urlopen(req) as r:
161	165	return json.loads(r.read().decode("utf-8"))
162	166

0 commit comments

Comments

0 (0)