fix bug where converting a UInt32 doesn't raise an OverflowError · pythonnet/pythonnet@0acc47a · GitHub

pythonnet / pythonnet Public

• Notifications You must be signed in to change notification settings
• Fork 780
• Star 5.5k

• Code
• Issues 153
• Pull requests 12
• Discussions
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit 0acc47a

Browse filesBrowse the repository at this point in the historyBrowse files

tonyroberts

committed

fix bug where converting a UInt32 doesn't raise an OverflowError

1 parent bc932a3 commit 0acc47a
Copy full SHA for 0acc47a

1 file changed

+8Lines changed: 8 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• pythonnet/src/runtime
  • converter.cs

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎pythonnet/src/runtime/converter.cs‎

Copy file name to clipboardExpand all lines: pythonnet/src/runtime/converter.cs

+8Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -540,6 +540,14 @@ static bool ToPrimitive(IntPtr value, Type obType, out Object result,
540	540	if (Exceptions.ErrorOccurred()) {
541	541	goto overflow;
542	542	}
	543	+
	544	+ IntPtr check = Runtime.PyLong_FromUnsignedLong(ui);
	545	+ int err = Runtime.PyObject_Compare(check, op);
	546	+ Runtime.Decref(check);
	547	+ if (0 != err || Exceptions.ErrorOccurred()) {
	548	+ goto overflow;
	549	+ }
	550	+
543	551	result = ui;
544	552	return true;
545	553

0 commit comments

Comments

0 (0)