Repository navigation
Commit 4e5afdf
committed
Fix access violation exception on shutdown (#1977)
When nulling the GC handles on shutdown the reference count of all objects pointed to by the IntPtr in the `CLRObject.reflectedObjects` are zero.
This caused an exception in some scenarios because `Runtime.PyObject_TYPE(reflectedClrObject)` is called while the reference counter is at zero.
After `TypeManager.RemoveTypes();` is called in the `Runtime.Shutdown()` method, reference count decrements to zero do not invoke `ClassBase.tp_clear` for managed objects anymore which normally is responsible for removing references from `CLRObject.reflectedObjects`. Collecting objects referenced in `CLRObject.reflectedObjects` only after leads to an unstable state in which the reference count for these object addresses is zero while still maintaining them to be used for further pseudo-cleanup. In that time, the memory could have been reclaimed already which leads to the exception.1 parent b112885 commit 4e5afdf
3 files changed
Lines changed: 6 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -38,6 +38,7 @@ | |||
| 38 | 38 | - Dmitriy Se ([@dmitriyse](https://github.com/dmitriyse)) | |
| 39 | 39 | - Félix Bourbonnais ([@BadSingleton](https://github.com/BadSingleton)) | |
| 40 | 40 | - Florian Treurniet ([@ftreurni](https://github.com/ftreurni)) | |
| 41 | + - Frank Witscher ([@Frawak](https://github.com/Frawak)) | ||
| 41 | 42 | - He-chien Tsai ([@t3476](https://github.com/t3476)) | |
| 42 | 43 | - Inna Wiesel ([@inna-w](https://github.com/inna-w)) | |
| 43 | 44 | - Ivan Cronyn ([@cronan](https://github.com/cronan)) | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -23,6 +23,7 @@ This document follows the conventions laid out in [Keep a CHANGELOG][]. | |||
| 23 | 23 | ||
| 24 | 24 | - Fixed RecursionError for reverse operators on C# operable types from python. See #2240 | |
| 25 | 25 | - Fixed probing for assemblies in `sys.path` failing when a path in `sys.path` has invalid characters. See #2376 | |
| 26 | + - Fixed possible access violation exception on shutdown. See ([#1977][i1977]) | ||
| 26 | 27 | ||
| 27 | 28 | ## [3.0.3](https://github.com/pythonnet/pythonnet/releases/tag/v3.0.3) - 2023-10-11 | |
| 28 | 29 | ||
@@ -970,3 +971,4 @@ This version improves performance on benchmarks significantly compared to 2.3. | |||
| 970 | 971 | [i1481]: https://github.com/pythonnet/pythonnet/issues/1481 | |
| 971 | 972 | [i1672]: https://github.com/pythonnet/pythonnet/pull/1672 | |
| 972 | 973 | [i2311]: https://github.com/pythonnet/pythonnet/issues/2311 | |
| 974 | + [i1977]: https://github.com/pythonnet/pythonnet/issues/1977 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -278,6 +278,8 @@ internal static void Shutdown() | |||
| 278 | 278 | ClearClrModules(); | |
| 279 | 279 | RemoveClrRootModule(); | |
| 280 | 280 | ||
| 281 | + TryCollectingGarbage(MaxCollectRetriesOnShutdown, forceBreakLoops: true); | ||
| 282 | + | ||
| 281 | 283 | NullGCHandles(ExtensionType.loadedExtensions); | |
| 282 | 284 | ClassManager.RemoveClasses(); | |
| 283 | 285 | TypeManager.RemoveTypes(); | |
@@ -295,8 +297,7 @@ internal static void Shutdown() | |||
| 295 | 297 | PyObjectConversions.Reset(); | |
| 296 | 298 | ||
| 297 | 299 | PyGC_Collect(); | |
| 298 | - bool everythingSeemsCollected = TryCollectingGarbage(MaxCollectRetriesOnShutdown, | ||
| 299 | - forceBreakLoops: true); | ||
| 300 | + bool everythingSeemsCollected = TryCollectingGarbage(MaxCollectRetriesOnShutdown); | ||
| 300 | 301 | Debug.Assert(everythingSeemsCollected); | |
| 301 | 302 | ||
| 302 | 303 | Finalizer.Shutdown(); | |
0 commit comments