FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Parameters marked with `ParameterAttributes.Out` are no longer return… · pythonnet/pythonnet@b7e2699 · GitHub

/ pythonnet Public

Commit b7e2699

Browse files
lostmsu
committed
Parameters marked with ParameterAttributes.Out are no longer returned in addition to the regular method return value (unless they are passed with ref or out keyword).
1 parent 57f4a80 commit b7e2699

3 files changed

Lines changed: 4 additions & 2 deletions

File tree

‎CHANGELOG.md‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ details about the cause of the failure
2323
able to access members that are part of the implementation class, but not the
2424
interface. Use the new __implementation__ or __raw_implementation__ properties to
2525
if you need to "downcast" to the implementation class.
26+
- Parameters marked with `ParameterAttributes.Out` are no longer returned in addition
27+
to the regular method return value (unless they are passed with `ref` or `out` keyword).
2628

2729
### Fixed
2830

‎src/runtime/methodbinder.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -534,7 +534,7 @@ static object[] TryConvertArguments(ParameterInfo[] pi, bool paramsArray,
534534
Runtime.XDecref(op);
535535
}
536536

537-
if (parameter.IsOut || isOut)
537+
if (isOut)
538538
{
539539
outs++;
540540
}

‎src/tests/test_method.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -761,7 +761,7 @@ def test_we_can_bind_to_encoding_get_string():
761761
read = 1
762762

763763
while read > 0:
764-
read, _ = stream.Read(buff, 0, buff.Length)
764+
read = stream.Read(buff, 0, buff.Length)
765765
temp = Encoding.UTF8.GetString(buff, 0, read)
766766
data.append(temp)
767767

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL