ParameterInfo.Name needs to be checked for null before usage (#1375) · pythonnet/pythonnet@d86bf3c · GitHub

pythonnet / pythonnet Public

• Notifications You must be signed in to change notification settings
• Fork 780
• Star 5.5k

• Code
• Issues 153
• Pull requests 12
• Discussions
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit d86bf3c

Browse filesBrowse the repository at this point in the historyBrowse files

filmor

authored

ParameterInfo.Name needs to be checked for null before usage (#1375)

This occured in trying to use F# code from Python. As the `.Name` property returns `null`, `ContainsKey` fails. Related documentation: https://docs.microsoft.com/en-us/dotnet/api/system.reflection.parameterinfo.name

1 parent 1afae4c commit d86bf3c
Copy full SHA for d86bf3c

2 files changed

+2-1Lines changed: 2 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• CHANGELOG.md
• src/runtime
  • methodbinder.cs

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎CHANGELOG.md‎

Copy file name to clipboardExpand all lines: CHANGELOG.md

+1Lines changed: 1 addition & 0 deletions

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -56,6 +56,7 @@ or the DLL must be loaded in advance. This must be done before calling any other
56	56	- `import` may now raise errors with more detail than "No module named X"
57	57	- Exception stacktraces on `PythonException.StackTrace` are now properly formatted
58	58	- Providing an invalid type parameter to a generic type or method produces a helpful Python error
	59	+ - Empty parameter names (as can be generated from F#) do not cause crashes
59	60
60	61	### Removed
61	62

Collapse file

‎src/runtime/methodbinder.cs‎

Copy file name to clipboardExpand all lines: src/runtime/methodbinder.cs

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -622,7 +622,7 @@ static object[] TryConvertArguments(ParameterInfo[] pi, bool paramsArray,
622	622	for (int paramIndex = 0; paramIndex < pi.Length; paramIndex++)
623	623	{
624	624	var parameter = pi[paramIndex];
625		- bool hasNamedParam = kwargDict.ContainsKey(parameter.Name);
	625	+ bool hasNamedParam = parameter.Name != null ? kwargDict.ContainsKey(parameter.Name) : false;
626	626	bool isNewReference = false;
627	627
628	628	if (paramIndex >= pyArgCount && !(hasNamedParam || (paramsArray && paramIndex == arrayStart)))

0 commit comments

Comments

0 (0)